From: Anton Arapov <anton@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Josh Stone <jistone@redhat.com>, Frank Eigler <fche@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Subject: Re: [RFC PATCH v3 4/6] uretprobes: return probe entry, prepare uretprobe
Date: Mon, 4 Mar 2013 11:49:16 +0100 [thread overview]
Message-ID: <20130304104916.GC32740@bandura.brq.redhat.com> (raw)
In-Reply-To: <20130303164029.GA20088@redhat.com>
On Sun, Mar 03, 2013 at 05:40:29PM +0100, Oleg Nesterov wrote:
> On 02/28, Anton Arapov wrote:
> >
> > @@ -69,6 +69,10 @@ struct uprobe_task {
> > enum uprobe_task_state state;
> > struct arch_uprobe_task autask;
> >
> > + /*
> > + * list for tracking uprobes with return consumers
> > + */
> > + struct hlist_head return_uprobes;
>
> Forgot to mention, at least you should also change uprobe_free_utask()
> to cleanup this list, the task can exit from inside the ret-probe'd
> function(s).
Yes, right. Thanks for the other mails as well. I will fix it for the
next RFC v4.
Anton.
> Oleg.
>
next prev parent reply other threads:[~2013-03-04 10:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 11:00 [RFC PATCH v3 0/6] uprobes: return probe implementation Anton Arapov
2013-02-28 11:00 ` [RFC PATCH v3 1/6] uretprobes: preparation patch Anton Arapov
2013-02-28 11:00 ` [RFC PATCH v3 2/6] uretprobes/x86: hijack return address Anton Arapov
2013-03-01 5:45 ` Ananth N Mavinakayanahalli
2013-03-01 11:00 ` Anton Arapov
2013-03-01 11:21 ` Ananth N Mavinakayanahalli
2013-02-28 11:00 ` [RFC PATCH v3 3/6] uretprobes: generalize xol_get_insn_slot() Anton Arapov
2013-02-28 20:01 ` Oleg Nesterov
2013-02-28 11:00 ` [RFC PATCH v3 4/6] uretprobes: return probe entry, prepare uretprobe Anton Arapov
2013-02-28 20:10 ` Oleg Nesterov
2013-03-04 14:14 ` Anton Arapov
2013-03-02 18:26 ` Oleg Nesterov
2013-03-03 16:40 ` Oleg Nesterov
2013-03-04 10:49 ` Anton Arapov [this message]
2013-02-28 11:00 ` [RFC PATCH v3 5/6] uretprobes: invoke return probe handlers Anton Arapov
2013-03-02 18:09 ` Oleg Nesterov
2013-02-28 11:00 ` [RFC PATCH v3 6/6] uretprobes: implemented, thus remove -ENOSYS Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304104916.GC32740@bandura.brq.redhat.com \
--to=anton@redhat.com \
--cc=ananth@in.ibm.com \
--cc=fche@redhat.com \
--cc=jistone@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).