From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v2 10/26] x86, irq: Convert irq_2_pin list to generic list
Date: Fri, 8 Mar 2013 14:50:55 -0500 [thread overview]
Message-ID: <20130308195055.GD6622@phenom.dumpdata.com> (raw)
In-Reply-To: <1360351703-20571-11-git-send-email-yinghai@kernel.org>
On Fri, Feb 08, 2013 at 11:28:07AM -0800, Yinghai Lu wrote:
> Now irq_2_pin list is own grown list.
I think you meant to say 'has its own list'. Not sure how
its growing?
> We can use generic list to replace it so we could generic helper
> functions to operate it.
You need to put the verb a bit earlier. Perhaps:
".. generic list to replace so that we can operate using
generic helper functions."
>
> Also make free_irq_cfg() free irq_2_pin list to support coming ioapic
> hotplug.
If you have them ready - could you say the titles of the patches here?
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> Cc: Joerg Roedel <joro@8bytes.org>
> ---
> arch/x86/include/asm/hw_irq.h | 2 +-
> arch/x86/kernel/apic/io_apic.c | 22 ++++++++++++----------
> 2 files changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
> index 10a78c3..69743f8 100644
> --- a/arch/x86/include/asm/hw_irq.h
> +++ b/arch/x86/include/asm/hw_irq.h
> @@ -121,7 +121,7 @@ struct irq_2_irte {
> * Most irqs are mapped 1:1 with pins.
> */
> struct irq_cfg {
> - struct irq_pin_list *irq_2_pin;
> + struct list_head irq_2_pin;
> cpumask_var_t domain;
> cpumask_var_t old_domain;
> u8 vector;
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 4c1a726..d2b4988 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -66,7 +66,7 @@
> #define __apicdebuginit(type) static type __init
>
> #define for_each_irq_pin(entry, head) \
> - for (entry = head; entry; entry = entry->next)
> + list_for_each_entry(entry, &head, list)
>
> /*
> * Is the SiS APIC rmw bug present ?
> @@ -176,8 +176,8 @@ void mp_save_irq(struct mpc_intsrc *m)
> }
>
> struct irq_pin_list {
> + struct list_head list;
> int apic, pin;
> - struct irq_pin_list *next;
> };
>
> static struct irq_pin_list *alloc_irq_pin_list(int node)
> @@ -213,6 +213,7 @@ int __init arch_early_irq_init(void)
> irq_reserve_irqs(0, legacy_pic->nr_legacy_irqs);
>
> for (i = 0; i < count; i++) {
> + INIT_LIST_HEAD(&cfg[i].irq_2_pin);
> irq_set_chip_data(i, &cfg[i]);
> zalloc_cpumask_var_node(&cfg[i].domain, GFP_KERNEL, node);
> zalloc_cpumask_var_node(&cfg[i].old_domain, GFP_KERNEL, node);
> @@ -245,6 +246,7 @@ static struct irq_cfg *alloc_irq_cfg(unsigned int irq, int node)
> goto out_cfg;
> if (!zalloc_cpumask_var_node(&cfg->old_domain, GFP_KERNEL, node))
> goto out_domain;
> + INIT_LIST_HEAD(&cfg->irq_2_pin);
> return cfg;
> out_domain:
> free_cpumask_var(cfg->domain);
> @@ -255,11 +257,15 @@ out_cfg:
>
> static void free_irq_cfg(unsigned int at, struct irq_cfg *cfg)
> {
> + struct irq_pin_list *entry, *tmp;
> +
> if (!cfg)
> return;
> irq_set_chip_data(at, NULL);
> free_cpumask_var(cfg->domain);
> free_cpumask_var(cfg->old_domain);
> + list_for_each_entry_safe(entry, tmp, &cfg->irq_2_pin, list)
> + kfree(entry);
> kfree(cfg);
> }
>
> @@ -420,15 +426,12 @@ static void ioapic_mask_entry(int apic, int pin)
> */
> static int __add_pin_to_irq_node(struct irq_cfg *cfg, int node, int apic, int pin)
> {
> - struct irq_pin_list **last, *entry;
> + struct irq_pin_list *entry;
>
> /* don't allow duplicates */
> - last = &cfg->irq_2_pin;
> - for_each_irq_pin(entry, cfg->irq_2_pin) {
> + for_each_irq_pin(entry, cfg->irq_2_pin)
> if (entry->apic == apic && entry->pin == pin)
> return 0;
> - last = &entry->next;
> - }
>
> entry = alloc_irq_pin_list(node);
> if (!entry) {
> @@ -439,7 +442,7 @@ static int __add_pin_to_irq_node(struct irq_cfg *cfg, int node, int apic, int pi
> entry->apic = apic;
> entry->pin = pin;
>
> - *last = entry;
> + list_add_tail(&entry->list, &cfg->irq_2_pin);
> return 0;
> }
>
> @@ -1622,8 +1625,7 @@ __apicdebuginit(void) print_IO_APICs(void)
> cfg = irq_get_chip_data(irq);
> if (!cfg)
> continue;
> - entry = cfg->irq_2_pin;
> - if (!entry)
> + if (list_empty(&cfg->irq_2_pin))
> continue;
> printk(KERN_DEBUG "IRQ%d ", irq);
> for_each_irq_pin(entry, cfg->irq_2_pin)
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2013-03-08 19:51 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 19:27 [PATCH v2 00/26] x86, irq: support ioapic device hotplug Yinghai Lu
2013-02-08 19:27 ` [PATCH v2 01/26] x86, irq: Change irq_remap_modify_chip_defaults to static Yinghai Lu
2013-02-08 19:27 ` [PATCH v2 02/26] x86, irq: Modify irq chip once for irq remapping Yinghai Lu
2013-03-08 20:07 ` Thomas Gleixner
2013-03-08 20:10 ` Thomas Gleixner
2013-03-09 7:25 ` Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 03/26] x86, irq: Print out MSI/MSI-X clearly Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 04/26] x86, irq: Show MSI-X in /proc/interrupt Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 05/26] x86, irq: Show pci device name for msi " Yinghai Lu
2013-03-08 19:46 ` Konrad Rzeszutek Wilk
2013-03-08 19:58 ` Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 06/26] x86, irq: Make dmar_msi/hpet_msi irq_chip name consistent Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 07/26] ia64, irq: Add dummy create_irq_nr() Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 08/26] iommu, irq: Allocate irq_desc for dmar_msi with local node Yinghai Lu
2013-02-08 20:45 ` Don Dutile
2013-02-08 20:58 ` Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 09/26] x86, irq: kill create_irq() Yinghai Lu
2013-03-08 19:48 ` Konrad Rzeszutek Wilk
2013-02-08 19:28 ` [PATCH v2 10/26] x86, irq: Convert irq_2_pin list to generic list Yinghai Lu
2013-03-08 19:50 ` Konrad Rzeszutek Wilk [this message]
2013-03-08 20:00 ` Yinghai Lu
2013-03-08 20:13 ` Konrad Rzeszutek Wilk
2013-02-08 19:28 ` [PATCH v2 11/26] genirq: Split __irq_reserve_irqs from irq_alloc_descs Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 12/26] x86, irq: Add realloc_irq_and_cfg_at() Yinghai Lu
2013-03-08 19:53 ` Konrad Rzeszutek Wilk
2013-03-09 7:22 ` Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 13/26] x86, irq: Move down arch_early_irq_init() Yinghai Lu
2013-03-08 19:53 ` Konrad Rzeszutek Wilk
2013-02-08 19:28 ` [PATCH v2 14/26] x86, irq: Split out alloc_ioapic_save_registers() Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 15/26] xen, irq: call irq_realloc_desc_at() at first Yinghai Lu
2013-03-08 19:43 ` Konrad Rzeszutek Wilk
2013-03-08 19:46 ` Yinghai Lu
2013-03-08 20:01 ` Konrad Rzeszutek Wilk
2013-02-08 19:28 ` [PATCH v2 16/26] x86, irq: pre-reserve irq range/realloc for booting path Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 17/26] x86, irq: Add ioapic_gsi_to_irq Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 18/26] genirq: Bail out early in free_desc() Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 19/26] x86, irq: More strict checking about registering ioapic Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 20/26] x86, irq: Make mp_register_ioapic handle hotadd ioapic Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 21/26] x86, irq: Add mp_unregister_ioapic to handle hot-remove ioapic Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 22/26] x86, irq: Make ioapics loop skip blank slots Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 23/26] x86, ioapic: Find usable ioapic id for 64bit Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 24/26] x86: Move declaration for mp_register_ioapic() Yinghai Lu
2013-02-08 19:28 ` [PATCH v2 25/26] PCI: Disable mem in the ioapic removing path Yinghai Lu
2013-02-08 21:14 ` Bjorn Helgaas
2013-02-08 22:33 ` Yinghai Lu
2013-02-08 23:18 ` Bjorn Helgaas
2013-02-08 19:28 ` [PATCH v2 26/26] PCI, x86, ACPI: Add ioapic hotplug support with acpi host bridge Yinghai Lu
2013-02-08 21:24 ` Bjorn Helgaas
2013-02-08 22:35 ` Yinghai Lu
2013-02-09 0:26 ` [PATCH v2 26-1/26] PCI, x86: Make ioapic hotplug support built-in Yinghai Lu
2013-02-09 0:26 ` [PATCH v2 26-2/26] PCI, x86, ACPI: Link acpi ioapic register to ioapic Yinghai Lu
2013-02-09 0:26 ` [PATCH v2 26-3/26] PCI, x86, ACPI: Enable ioapic hotplug support with acpi host bridge Yinghai Lu
2013-02-09 0:26 ` [PATCH v2 26-4/26] PCI, x86, ACPI: get ioapic address from acpi device Yinghai Lu
2013-02-11 9:34 ` [PATCH v2 00/26] x86, irq: support ioapic device hotplug Ingo Molnar
2013-02-12 6:10 ` H. Peter Anvin
2013-02-13 2:36 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308195055.GD6622@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=sebastian@breakpoint.cc \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).