From: Samuel Ortiz <sameo@linux.intel.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rob Landley <rob@landley.net>, Felipe Balbi <balbi@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
Wolfram Sang <w.sang@pengutronix.de>,
Luigi Semenzato <semenzato@chromium.org>,
Rob Herring <rob.herring@calxeda.com>,
Che-Liang Chiou <clchiou@chromium.org>,
Jonathan Kliegman <kliegs@chromium.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Sourav Poddar <sourav.poddar@ti.com>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Alban Bedel <alban.bedel@avionic-design.de>,
Roland Stigge <stigge@antcom.de>,
Vincent Palatin <vpalatin@chromium.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Bill Pemberton <wfp5p@virginia.edu>
Subject: Re: [PATCH v6 0/6] Add ChromeOS Embedded Controller support
Date: Wed, 20 Mar 2013 09:14:56 +0100 [thread overview]
Message-ID: <20130320081456.GA5939@zurbaran> (raw)
In-Reply-To: <CAPnjgZ1=w5GyfGrSFG63SFTErTQQUQQiBmgC8BVMzy4kLVkPDg@mail.gmail.com>
Hi Simon,
On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote:
> Hi Samuel,
>
> On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote:
> >> Hi Simon,
> >>
> >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote:
> >> > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation
> >> > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3
> >> > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt
> >> > line is used to indicate when the EC needs service.
> >> All 6 patches applied to my mfd-next tree, thanks a lot.
> > Actually, this one fails to build when CONFIG_OF is not set:
> >
> > drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of function
> > ‘of_device_is_available’ [-Werror=implicit-function-declaration]
> >
> > If the check in cros_ec_probe_i2c() is really needed then you'll need to inline
> > of_device_is_available() into a NOP in include/linux/of.h.
>
> Actually I suppose that call is not really needed. Would you like to
> remove it, or shall I send a new patch?
I will remove it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-03-20 8:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 22:08 [PATCH v6 0/6] Add ChromeOS Embedded Controller support Simon Glass
2013-02-25 22:08 ` [PATCH v6 1/6] mfd: Add ChromeOS EC messages header Simon Glass
2013-02-25 22:08 ` [PATCH v6 2/6] mfd: Add ChromeOS EC implementation Simon Glass
2013-02-25 22:08 ` [PATCH v6 3/6] mfd: Add ChromeOS EC I2C driver Simon Glass
2013-02-25 22:08 ` [PATCH v6 4/6] mfd: Add ChromeOS EC SPI driver Simon Glass
2013-02-25 22:08 ` [PATCH v6 5/6] Input: matrix-keymap: Add function to read the new DT binding Simon Glass
2013-02-25 22:08 ` [PATCH v6 6/6] Input: Add ChromeOS EC keyboard driver Simon Glass
2013-02-25 22:12 ` Dmitry Torokhov
2013-02-27 5:13 ` [PATCH v6 0/6] Add ChromeOS Embedded Controller support Simon Glass
2013-02-27 8:40 ` Samuel Ortiz
2013-02-28 0:25 ` Simon Glass
2013-03-18 18:41 ` Simon Glass
2013-03-20 0:56 ` Samuel Ortiz
2013-03-20 1:12 ` Samuel Ortiz
2013-03-20 2:01 ` Simon Glass
2013-03-20 8:14 ` Samuel Ortiz [this message]
2013-03-20 8:52 ` Samuel Ortiz
2013-03-21 1:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320081456.GA5939@zurbaran \
--to=sameo@linux.intel.com \
--cc=alban.bedel@avionic-design.de \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clchiou@chromium.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=javier@dowhile0.org \
--cc=kliegs@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=stigge@antcom.de \
--cc=tony@atomide.com \
--cc=vpalatin@chromium.org \
--cc=w.sang@pengutronix.de \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).