From: David Miller <davem@davemloft.net>
To: josright123@gmail.com
Cc: wfp5p@virginia.edu, matthew@mattleach.net,
gregkh@linuxfoundation.org, joseph_chang@davicom.com.tw,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips
Date: Mon, 25 Mar 2013 13:09:24 -0400 (EDT) [thread overview]
Message-ID: <20130325.130924.1771800578429290181.davem@davemloft.net> (raw)
In-Reply-To: <1364198682-1589-1-git-send-email-josright123@gmail.com>
From: Joseph CHANG <josright123@gmail.com>
Date: Mon, 25 Mar 2013 16:04:42 +0800
> #define CARDNAME "dm9000"
> -#define DRV_VERSION "1.31"
> +/* [KERN-ADD-1](upgrade) */
> +#define DRV_VERSION "1.39"
...
> + /* [KERN-ADD-2] */
These kinds of comments are absolutely inapproprate.
next prev parent reply other threads:[~2013-03-25 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 8:04 [PATCH 1/1] ethernet driver: dm9000: davicom: Upgrade the driver to suit for all DM9000 series chips Joseph CHANG
2013-03-25 17:09 ` David Miller [this message]
2013-03-25 20:08 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325.130924.1771800578429290181.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=joseph_chang@davicom.com.tw \
--cc=josright123@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@mattleach.net \
--cc=netdev@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).