From: Arnd Bergmann <arnd@arndb.de>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Olof Johansson <olof@lixom.net>,
"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@jcrosoft.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"linux-arm-kernel" <linux-arm-kernel@lists.infradead.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] at91: fixes for 3.9-rc #2
Date: Tue, 26 Mar 2013 11:05:21 +0000 [thread overview]
Message-ID: <201303261105.22173.arnd@arndb.de> (raw)
In-Reply-To: <51517EEB.7030709@atmel.com>
On Tuesday 26 March 2013, Nicolas Ferre wrote:
> Indeed, at first sight its looks like a nice solution. But I wonder if
> we add several nodes in this kind of .dtsi files, we may end up with
> mess between APB peripherals and board specific ones like leds, NAND, etc.
> Moreover, the plain and full naming of the node makes it identifiable
> without doubts, even someone not completely familiar with DT.
>
> I slightly prefer to keep it like this, but I can still change my mind ;-)
If you don't want to use the labels, it's probably better to drop from
the dtsi files. I think you can also write
ahb/apb/ethernet@802c000 {
phy-mode = "rmii";
status = "okay";
};
although I think most people prefer the labels, and I have not tried
the above.
Back to the bug fix, I think we can have a simpler version for 3.9
if you just mark the ethernet node as "disabled" in the
at91sam9g15.dtsi file, and then do the patch to change the default
in an add-on patch for 3.10.
Arnd
next prev parent reply other threads:[~2013-03-26 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 10:16 [GIT PULL] at91: fixes for 3.9-rc #2 Nicolas Ferre
2013-03-26 10:22 ` Arnd Bergmann
2013-03-26 10:56 ` Nicolas Ferre
2013-03-26 11:05 ` Arnd Bergmann [this message]
2013-03-27 11:28 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303261105.22173.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).