From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jasowang@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com,
edumazet@google.com
Subject: Re: [PATCH net-next 1/3] net: core: let skb_partial_csum_set() set transport header
Date: Wed, 27 Mar 2013 13:07:38 -0400 (EDT) [thread overview]
Message-ID: <20130327.130738.1384912506225105640.davem@davemloft.net> (raw)
In-Reply-To: <1364395376.15753.5.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 27 Mar 2013 07:42:56 -0700
> On Wed, 2013-03-27 at 17:11 +0800, Jason Wang wrote:
>> For untrusted packets with partial checksum, we need to set the transport header
>> for precise packet length estimation. We can just let skb_pratial_csum_set() to
>> do this to avoid extra call to skb_flow_dissect() and simplify the caller.
>>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> net/core/skbuff.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>> index 31c6737..ba64614 100644
>> --- a/net/core/skbuff.c
>> +++ b/net/core/skbuff.c
>> @@ -3370,6 +3370,7 @@ bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off)
>> skb->ip_summed = CHECKSUM_PARTIAL;
>> skb->csum_start = skb_headroom(skb) + start;
>> skb->csum_offset = off;
>> + skb_set_transport_header(skb, start);
>> return true;
>> }
>> EXPORT_SYMBOL_GPL(skb_partial_csum_set);
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2013-03-27 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 9:11 [PATCH net-next 1/3] net: core: let skb_partial_csum_set() set transport header Jason Wang
2013-03-27 9:11 ` [PATCH net-next 2/3] net: core: introduce skb_probe_transport_header() Jason Wang
2013-03-27 14:45 ` Eric Dumazet
2013-03-27 17:07 ` David Miller
2013-03-27 9:11 ` [PATCH net-next 3/3] net: switch to use skb_probe_transport_header() Jason Wang
2013-03-27 14:46 ` Eric Dumazet
2013-03-27 17:07 ` David Miller
2013-03-27 14:42 ` [PATCH net-next 1/3] net: core: let skb_partial_csum_set() set transport header Eric Dumazet
2013-03-27 17:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327.130738.1384912506225105640.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).