From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, ak@linux.intel.com, acme@redhat.com,
namhyung.kim@lge.com
Subject: Re: [PATCH v7 11/18] perf tools: add mem access sampling core support
Date: Wed, 27 Mar 2013 15:14:25 +0100 [thread overview]
Message-ID: <20130327141425.GC1092@krava.brq.redhat.com> (raw)
In-Reply-To: <1359040242-8269-12-git-send-email-eranian@google.com>
On Thu, Jan 24, 2013 at 04:10:35PM +0100, Stephane Eranian wrote:
SNIP
>
> +static void ip__resolve_data(struct machine *self, struct thread *thread,
> + u8 m,
> + struct addr_map_symbol *ams,
> + u64 addr)
> +{
> + struct addr_location al;
> +
> + memset(&al, 0, sizeof(al));
> +
> + thread__find_addr_location(thread, self, m, MAP__VARIABLE, addr, &al,
> + NULL);
> + ams->addr = addr;
> + ams->al_addr = al.addr;
> + ams->sym = al.sym;
> + ams->map = al.map;
> +}
> +
> +struct mem_info *machine__resolve_mem(struct machine *self,
> + struct thread *thr,
> + struct perf_sample *sample,
> + u8 cpumode)
> +{
> + struct mem_info *mi;
> +
> + mi = calloc(1, sizeof(struct mem_info));
> + if (!mi)
> + return NULL;
> +
> + ip__resolve_ams(self, thr, &mi->iaddr, sample->ip);
> + ip__resolve_data(self, thr, cpumode, &mi->daddr, sample->addr);
question, should this be the other way around? like:
ip__resolve_ams(machine, thr, &mi->daddr, sample->addr);
ip__resolve_data(machine, thr, cpumode, &mi->iaddr, sample->ip);
we have correct cpumode for sample->ip, but I think it's the
PEBS->dla (sample->addr) where we need to guess.. right?
that makes me think that we could probably use ip__resolve_data
for both.. hummm.. but we could access data cross the user/kernel
boundary, so cpumode would be different for ip and accessed data
thanks,
jirka
next prev parent reply other threads:[~2013-03-27 14:14 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 15:10 [PATCH v7 00/18] perf: add memory access sampling support Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-25 12:16 ` [tip:perf/x86] perf/x86: " tip-bot for Andi Kleen
2013-04-02 9:38 ` [tip:perf/core] " tip-bot for Andi Kleen
2013-01-24 15:10 ` [PATCH v7 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-25 12:17 ` [tip:perf/x86] perf/x86: Improve " tip-bot for Stephane Eranian
2013-04-02 9:39 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 03/18] perf/x86: add flags to event constraints Stephane Eranian
2013-01-25 12:18 ` [tip:perf/x86] perf/x86: Add " tip-bot for Stephane Eranian
2013-04-02 9:40 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 04/18] perf, core: Add a concept of a weightened sample v2 Stephane Eranian
2013-01-25 12:20 ` [tip:perf/x86] perf/core: Add weighted samples tip-bot for Andi Kleen
2013-04-02 9:42 ` [tip:perf/core] " tip-bot for Andi Kleen
2013-01-24 15:10 ` [PATCH v7 05/18] perf, tools: Add support for weight v7 (modified) Stephane Eranian
2013-04-02 9:49 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2013-01-24 15:10 ` [PATCH v7 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-25 9:01 ` Ingo Molnar
2013-01-25 15:30 ` Stephane Eranian
2013-01-29 10:37 ` Michael Ellerman
2013-02-15 19:46 ` Sukadev Bhattiprolu
2013-02-16 2:45 ` Benjamin Herrenschmidt
2013-02-16 8:41 ` Ingo Molnar
2013-02-16 14:14 ` Stephane Eranian
2013-01-25 12:21 ` [tip:perf/x86] perf: Add " tip-bot for Stephane Eranian
2013-04-02 9:43 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-25 12:22 ` [tip:perf/x86] perf/x86: Add " tip-bot for Stephane Eranian
2013-04-02 9:44 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2013-01-25 12:23 ` [tip:perf/x86] perf/x86: Export " tip-bot for Stephane Eranian
2013-04-02 9:45 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2013-01-25 12:24 ` [tip:perf/x86] perf/x86: Add " tip-bot for Stephane Eranian
2013-04-02 9:47 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 11/18] perf tools: add mem access sampling core support Stephane Eranian
2013-03-27 14:14 ` Jiri Olsa [this message]
2013-03-27 14:20 ` Peter Zijlstra
2013-03-27 14:34 ` Jiri Olsa
2013-03-27 14:48 ` Stephane Eranian
2013-03-27 16:56 ` Arnaldo Carvalho de Melo
2013-03-28 14:24 ` Stephane Eranian
2013-03-28 15:00 ` Arnaldo Carvalho de Melo
2013-03-28 15:06 ` Stephane Eranian
2013-03-28 15:12 ` Arnaldo Carvalho de Melo
2013-03-28 15:15 ` Stephane Eranian
2013-03-27 14:23 ` Jiri Olsa
2013-04-02 9:50 ` [tip:perf/core] perf tools: Add " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 12/18] perf report: add support for mem access profiling Stephane Eranian
2013-04-02 9:53 ` [tip:perf/core] perf report: Add " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 13/18] perf record: add " Stephane Eranian
2013-04-02 9:51 ` [tip:perf/core] perf record: Add " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-04-02 9:55 ` [tip:perf/core] perf tools: Add " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2013-01-25 12:25 ` [tip:perf/x86] perf: Add " tip-bot for Stephane Eranian
2013-04-02 9:48 ` [tip:perf/core] " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2013-04-02 9:57 ` [tip:perf/core] perf machine: Detect " tip-bot for Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 17/18] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2013-01-24 15:10 ` [PATCH v7 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
2013-04-02 9:58 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-25 8:55 ` [PATCH v7 00/18] perf: add memory access sampling support Ingo Molnar
2013-01-25 15:28 ` Stephane Eranian
2013-01-25 10:38 ` Ingo Molnar
2013-02-05 13:03 ` Stephane Eranian
2013-02-05 15:35 ` Arnaldo Carvalho de Melo
2013-02-06 13:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327141425.GC1092@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).