From: Jan Kara <jack@suse.cz>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fsfreeze: moving from uniterruptible to killable
Date: Wed, 27 Mar 2013 15:34:47 +0100 [thread overview]
Message-ID: <20130327143447.GB1771@quack.suse.cz> (raw)
In-Reply-To: <CANGUGtD9BNQO9pvO+yeKHc0qojk61fKYDgKm8kfWzu8pCk=YJw@mail.gmail.com>
On Wed 27-03-13 12:39:10, Marco Stornelli wrote:
> 2013/3/26 Jan Kara <jack@suse.cz>:
> > On Sun 24-03-13 10:10:59, Marco Stornelli wrote:
> >> When a fs is frozen, a process can hang because we wait in
> >> uniterruptible state. We give the user the possibility to kill the process.
> > Yes, but it needs slightly more work as you probably know... (bailing out
> > properly when the signal arrives).
> >
> > Honza
> >
>
> Of course, indeed, it was only an RFC to start a discussion, not a
> patch :) The point was: is this kind of change a behaviour that can
> break user-space in some way? IMHO no, but I'd like to have a
> discussion about that before to start coding. What do you think?
Killable wait is almost always safe WRT to userspace breakage. In this
case I cannot see how it could matter. That's why I agree it's a good thing
to do.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-03-27 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 9:10 [RFC] fsfreeze: moving from uniterruptible to killable Marco Stornelli
2013-03-26 21:15 ` Jan Kara
2013-03-27 11:39 ` Marco Stornelli
2013-03-27 14:34 ` Jan Kara [this message]
2013-03-27 15:41 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327143447.GB1771@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).