From: Anton Arapov <anton@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] uprobes/tracing: Kill the pointless seq_print_ip_sym() call
Date: Tue, 2 Apr 2013 10:57:45 +0200 [thread overview]
Message-ID: <20130402085745.GC24889@bandura.brq.redhat.com> (raw)
In-Reply-To: <20130329181543.GA20690@redhat.com>
On Fri, Mar 29, 2013 at 07:15:43PM +0100, Oleg Nesterov wrote:
> seq_print_ip_sym(ip) in print_uprobe_event() is pointless,
> kallsyms_lookup(ip) can not resolve a user-space address.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> ---
> kernel/trace/trace_uprobe.c | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index af5b773..8e00901 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e
> field = (struct uprobe_trace_entry_head *)iter->ent;
> tu = container_of(event, struct trace_uprobe, call.event);
>
> - if (!trace_seq_printf(s, "%s: (", tu->call.name))
> - goto partial;
> -
> - if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
> - goto partial;
> -
> - if (!trace_seq_puts(s, ")"))
> + if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip))
> goto partial;
>
> data = (u8 *)&field[1];
> --
> 1.5.5.1
Acked-by: Anton Arapov <anton@redhat.com>
next prev parent reply other threads:[~2013-04-02 8:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 18:15 [PATCH 0/4] uprobes/tracing: uretprobes, initial preparations Oleg Nesterov
2013-03-29 18:15 ` [PATCH 1/4] uprobes/tracing: Kill the pointless task_pt_regs() calls Oleg Nesterov
2013-04-02 8:57 ` Anton Arapov
2013-04-04 14:24 ` Srikar Dronamraju
2013-03-29 18:15 ` [PATCH 2/4] uprobes/tracing: Kill the pointless seq_print_ip_sym() call Oleg Nesterov
2013-04-02 8:57 ` Anton Arapov [this message]
2013-04-04 14:24 ` Srikar Dronamraju
2013-03-29 18:15 ` [PATCH 3/4] uprobes/tracing: Kill the pointless local_save_flags/preempt_count calls Oleg Nesterov
2013-04-02 8:58 ` Anton Arapov
2013-04-04 14:25 ` Srikar Dronamraju
2013-04-05 3:47 ` Masami Hiramatsu
2013-04-05 15:01 ` Oleg Nesterov
2013-04-08 9:29 ` Masami Hiramatsu
2013-04-10 14:58 ` [PATCH 0/1] uprobes/tracing: Don't pass addr=ip to perf_trace_buf_submit() Oleg Nesterov
2013-04-10 14:58 ` [PATCH 1/1] " Oleg Nesterov
2013-04-11 10:19 ` Masami Hiramatsu
2013-04-13 9:28 ` Srikar Dronamraju
2013-04-11 10:38 ` [PATCH 0/1] " Masami Hiramatsu
2013-04-11 11:59 ` Oleg Nesterov
2013-04-12 18:01 ` Steven Rostedt
2013-04-12 21:19 ` Steven Rostedt
2013-04-13 14:02 ` [PATCH 0/1] uprobes/perf: Avoid perf_trace_buf_prepare/submit if ->perf_events is empty Oleg Nesterov
2013-04-13 14:02 ` [PATCH 1/1] " Oleg Nesterov
2013-04-13 18:22 ` [PATCH 0/1] " Oleg Nesterov
2013-04-08 15:58 ` [PATCH 3/4] uprobes/tracing: Kill the pointless local_save_flags/preempt_count calls Steven Rostedt
2013-04-09 14:58 ` Oleg Nesterov
2013-04-09 15:12 ` Steven Rostedt
2013-03-29 18:15 ` [PATCH 4/4] uprobes/tracing: generalize struct uprobe_trace_entry_head Oleg Nesterov
2013-04-02 8:59 ` Anton Arapov
2013-04-04 14:25 ` Srikar Dronamraju
2013-04-08 15:55 ` Steven Rostedt
2013-04-09 14:50 ` Oleg Nesterov
2013-04-09 15:07 ` Steven Rostedt
2013-04-09 19:32 ` [PATCH v2 0/7] uprobes/tracing: uretprobes Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 1/7] uprobes/tracing: Generalize struct uprobe_trace_entry_head Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 2/7] uprobes/tracing: Introduce uprobe_{trace,perf}_print() helpers Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 3/7] uprobes/tracing: Introduce is_ret_probe() and uretprobe_dispatcher() Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 4/7] uprobes/tracing: Make uprobe_{trace,perf}_print() uretprobe-friendly Oleg Nesterov
2013-04-13 9:33 ` Srikar Dronamraju
2013-04-09 19:32 ` [PATCH v2 5/7] uprobes/tracing: Make register_uprobe_event() paths uretprobe-friendly Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 6/7] uprobes/tracing: Make seq_printf() code uretprobe-friendly Oleg Nesterov
2013-04-09 19:32 ` [PATCH v2 7/7] uprobes/tracing: Change create_trace_uprobe() to support uretprobes Oleg Nesterov
2013-04-01 16:08 ` [PATCH 0/6] uprobes/tracing: uretprobes Oleg Nesterov
2013-04-01 16:08 ` [PATCH 1/6] uprobes/tracing: Introduce uprobe_{trace,perf}_print() helpers Oleg Nesterov
2013-04-07 13:58 ` Srikar Dronamraju
2013-04-01 16:08 ` [PATCH 2/6] uprobes/tracing: Introduce is_ret_probe() and uretprobe_dispatcher() Oleg Nesterov
2013-04-07 14:12 ` Srikar Dronamraju
2013-04-01 16:08 ` [PATCH 3/6] uprobes/tracing: Make uprobe_{trace,perf}_print() uretprobe-friendly Oleg Nesterov
2013-04-07 10:31 ` Srikar Dronamraju
2013-04-09 13:33 ` Oleg Nesterov
2013-04-13 9:31 ` Srikar Dronamraju
2013-04-08 17:08 ` Steven Rostedt
2013-04-01 16:08 ` [PATCH 4/6] uprobes/tracing: Make register_uprobe_event() paths uretprobe-friendly Oleg Nesterov
2013-04-07 14:14 ` Srikar Dronamraju
2013-04-01 16:08 ` [PATCH 5/6] uprobes/tracing: Make seq_printf() code uretprobe-friendly Oleg Nesterov
2013-04-07 14:15 ` Srikar Dronamraju
2013-04-01 16:09 ` [PATCH 6/6] uprobes/tracing: Change create_trace_uprobe() to support uretprobes Oleg Nesterov
2013-04-07 14:17 ` Srikar Dronamraju
2013-04-02 13:25 ` [PATCH 0/6] uprobes/tracing: uretprobes Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402085745.GC24889@bandura.brq.redhat.com \
--to=anton@redhat.com \
--cc=ananth@in.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).