From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost_net: remove tx polling state
Date: Thu, 11 Apr 2013 16:16:57 -0400 (EDT) [thread overview]
Message-ID: <20130411.161657.2074095162745735091.davem@davemloft.net> (raw)
In-Reply-To: <20130411072430.GC17063@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 11 Apr 2013 10:24:30 +0300
> On Thu, Apr 11, 2013 at 02:50:48PM +0800, Jason Wang wrote:
>> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle polling
>> errors when setting backend), we in fact track the polling state through
>> poll->wqh, so there's no need to duplicate the work with an extra
>> vhost_net_polling_state. So this patch removes this and make the code simpler.
>>
>> This patch also removes the all tx starting/stopping code in tx path according
>> to Michael's suggestion.
>>
>> Netperf test shows almost the same result in stream test, but gets improvements
>> on TCP_RR tests (both zerocopy or copy) especially on low load cases.
>>
>> Tested between multiqueue kvm guest and external host with two direct
>> connected 82599s.
...
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Less code and better speed, what's not to like.
> Davem, could you pick this up for 3.10 please?
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied to net-next, thanks everyone.
next prev parent reply other threads:[~2013-04-11 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 6:50 [PATCH] vhost_net: remove tx polling state Jason Wang
2013-04-11 7:24 ` Michael S. Tsirkin
2013-04-11 20:16 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 4:31 Jason Wang
2013-03-07 21:25 ` David Miller
2013-03-10 16:50 ` Michael S. Tsirkin
2013-03-11 7:09 ` Jason Wang
2013-03-11 7:33 ` Jason Wang
2013-03-11 8:26 ` Michael S. Tsirkin
2013-03-11 8:29 ` Michael S. Tsirkin
2013-03-11 8:45 ` Jason Wang
2013-03-11 8:47 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411.161657.2074095162745735091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).