From: Dan Carpenter <firstname.lastname@example.org> To: Dave Jones <email@example.com>, Andrew Morton <firstname.lastname@example.org>, Joe Perches <email@example.com>, Andy Whitcroft <firstname.lastname@example.org>, LKML <email@example.com>, Jacob Pan <firstname.lastname@example.org> Subject: Re: [PATCH] checkpatch: Warn on comparisons to true and false Date: Thu, 11 Apr 2013 11:19:43 +0300 [thread overview] Message-ID: <20130411081943.GA6772@mwanda> (raw) In-Reply-To: <20130411021415.GA16118@redhat.com> On Wed, Apr 10, 2013 at 10:14:15PM -0400, Dave Jones wrote: > On Wed, Apr 10, 2013 at 03:57:51PM -0700, Andrew Morton wrote: > > On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches <email@example.com> wrote: > > > > > Comparisons of A to true and false are better written > > > as A and !A. > > > > > > Bleat a message on use. > > > > hm. I'm counting around 1,100 instances of "== true" and "== false". > > > > That's a lot of people to shout at. Is it really worthwhile? > > "foo==true" is a bit of a waste of space but I can't say that I find it > > terribly offensive. > > It would be interesting to see how many people have historically screwed > up and used (!a) when they mean (a) and vice versa, versus spelling > it out longform. I'd be surprised if the results weren't skewed > in favour of the more verbose form. I see a the occasional reversed test in Smatch but normally these kind of bugs are detected with basic testing so they are rare. regards, dan carpenter
next prev parent reply other threads:[~2013-04-11 8:20 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-10 3:17 Joe Perches 2013-04-10 9:33 ` Andy Whitcroft 2013-04-10 11:27 ` Joe Perches 2013-04-10 12:41 ` Andy Whitcroft 2013-04-10 22:57 ` Andrew Morton 2013-04-11 1:07 ` Joe Perches 2013-04-11 2:14 ` Dave Jones 2013-04-11 3:47 ` Joe Perches 2013-04-11 8:19 ` Dan Carpenter [this message] 2013-04-11 8:29 ` Joe Perches 2013-04-11 11:56 ` Bjørn Mork 2013-04-11 14:25 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130411081943.GA6772@mwanda \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] checkpatch: Warn on comparisons to true and false' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).