From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] x86, FPU: Fix FPU initialization
Date: Tue, 16 Apr 2013 11:25:28 +0200 [thread overview]
Message-ID: <20130416092528.GF9569@gmail.com> (raw)
In-Reply-To: <20130415220406.GD12144@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Apr 15, 2013 at 05:54:15PM +0200, Borislav Petkov wrote:
> > On Mon, Apr 15, 2013 at 12:18:25PM +0200, Ingo Molnar wrote:
> > > It was tip:master with x86/cpu merged in freshly.
> >
> > Ok, some more observations. I can trigger some oops similar yours (I
> > haven't caught mine yet over serial or such) with latest tip/master +
> > tip:x86/cpu.
>
> Ok, here's the deal - it looks like a corruption which causes a couple
> of different backtraces with different functions in the call trace. I've
> bisected tip:x86/cpu and the evildoers are:
Correct, 'late effects of memory corruption' was my first impression too, from the
crash pattern.
>
> commit 3019653a57585602690fd38679326e9337f7ed7f
> Author: Borislav Petkov <bp@suse.de>
> Date: Wed Apr 10 21:37:03 2013 +0200
>
> x86/fpu: Fix FPU initialization
>
> commit c70293d0e3fef6b989cd8268027d410cf06ce384
> Author: H. Peter Anvin <hpa@zytor.com>
> Date: Mon Apr 8 17:57:43 2013 +0200
>
> x86: Get rid of ->hard_math and all the FPU asm fu
>
>
> I'll venture a guess and say that if you revert those, your .config
> would boot on your K8 too.
>
> So, I'd propose we take those 2 out for more careful inspection and
> fixing and the rest of tip:x86/cpu can go upstream in the upcoming merge
> window. IMHO of course.
I've got limited extra capacity right now - but if Peter rebases tip:x86/cpu or
you send a pullable update of tip:x86/cpu I can stick it into -tip testing and
yell if it goes wrong.
Thanks,
Ingo
next prev parent reply other threads:[~2013-04-16 9:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 15:57 [PATCH 0/4] x86: FPU detection in C Borislav Petkov
2013-04-08 15:57 ` [PATCH 1/4] x86: Get rid of ->hard_math and all the FPU asm fu Borislav Petkov
2013-04-08 16:26 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
2013-06-12 20:48 ` [tip:x86/fpu] " tip-bot for H. Peter Anvin
2013-04-08 15:57 ` [PATCH 2/4] x86: Fold-in trivial check_config function Borislav Petkov
2013-04-08 16:27 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2013-04-16 13:51 ` tip-bot for Borislav Petkov
2013-04-08 15:57 ` [PATCH 3/4] x86, AMD: Correct {rd,wr}msr_amd_safe warnings Borislav Petkov
2013-04-08 16:28 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2013-04-16 13:53 ` tip-bot for Borislav Petkov
2013-04-08 15:57 ` [PATCH 4/4] x86, CPU, AMD: Drop useless label Borislav Petkov
2013-04-08 16:29 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2013-04-16 13:54 ` tip-bot for Borislav Petkov
2013-04-10 11:08 ` [PATCH 0/4] x86: FPU detection in C Ingo Molnar
2013-04-10 12:24 ` Borislav Petkov
2013-04-10 12:25 ` Ingo Molnar
2013-04-10 13:32 ` Borislav Petkov
2013-04-10 15:35 ` H. Peter Anvin
2013-04-10 16:11 ` Borislav Petkov
2013-04-10 21:29 ` [PATCH] x86, FPU: Fix FPU initialization Borislav Petkov
2013-04-11 12:09 ` Ingo Molnar
2013-04-11 14:23 ` Borislav Petkov
2013-04-11 19:26 ` H. Peter Anvin
2013-04-11 20:23 ` Borislav Petkov
2013-04-12 5:32 ` Ingo Molnar
2013-04-12 5:34 ` H. Peter Anvin
2013-04-12 9:47 ` Borislav Petkov
2013-04-12 11:26 ` Borislav Petkov
2013-04-15 10:08 ` Ingo Molnar
2013-04-15 10:17 ` Borislav Petkov
2013-04-15 10:18 ` Ingo Molnar
2013-04-15 15:54 ` Borislav Petkov
2013-04-15 22:04 ` Borislav Petkov
2013-04-16 9:25 ` Ingo Molnar [this message]
2013-04-16 9:48 ` Borislav Petkov
2013-04-16 10:08 ` [GIT PULL] Rebase tip:x86/cpu Borislav Petkov
2013-04-16 11:35 ` Ingo Molnar
2013-04-16 11:33 ` [PATCH] x86, FPU: Fix FPU initialization Ingo Molnar
2013-04-29 14:04 [PATCH 0/3] FPU detection in C, second try Borislav Petkov
2013-04-29 14:04 ` [PATCH 1/3] x86: Get rid of ->hard_math and all the FPU asm fu Borislav Petkov
2013-04-29 14:04 ` [PATCH 2/3] x86: Sanity-check static_cpu_has usage Borislav Petkov
2013-04-29 15:38 ` H. Peter Anvin
2013-04-29 14:04 ` [PATCH 3/3] x86, FPU: Do not use static_cpu_has before alternatives Borislav Petkov
2013-04-29 15:42 ` H. Peter Anvin
2013-04-29 18:51 ` Borislav Petkov
2013-04-29 18:58 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416092528.GF9569@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).