From: David Howells <dhowells@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: [PATCH 00/28] Privatise procfs internals [RFC]
Date: Tue, 16 Apr 2013 19:25:51 +0100 [thread overview]
Message-ID: <20130416182550.27773.89310.stgit@warthog.procyon.org.uk> (raw)
Here is a series of patches to make the procfs internals private to the procfs
filesystem. This is built on top of the patches to eliminate
create_proc_read_entry() after the kill-read_proc_t tag.
These patches include fixes for the places that are attempting to abuse
proc_dir_entry->count and doing it incorrectly because PID namespaces now
exist.
All accesses to the PDE struct have been replaced with out-of-line accessor
functions. This is a bit less efficient than it used to be, but this could be
mitigated by using inode->i_private.
The internal procfs structs have moved to fs/procfs/internal.h. Some of the
remaining stuff in linux/proc_fs.h has been split out to linux/kcore.h and
linux/proc_ns.h as they's separate specialised intefaces.
These patches can be seen here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=vfs-experimental
David
---
David Howells (28):
Include missing linux/slab.h inclusions
Include missing linux/magic.h inclusions
proc: Split kcore bits from linux/procfs.h into linux/kcore.h
proc: Supply PDE attribute setting accessor functions
proc: Uninline pid_delete_dentry()
proc: Move proc_fd() to fs/proc/fd.h
proc: Split the namespace stuff out into linux/proc_ns.h
proc: Move PDE_NET() to fs/proc/proc_net.c
proc: Move some bits from linux/proc_fs.h to linux/{of.h,signal.h,tty.h}
proc: Add proc_mkdir_data()
rtl8187se: Use a dir under /proc/net/r8180/
rtl8192u: Don't need to save device proc dir PDE
airo: Use remove_proc_subtree()
proc: Supply an accessor for getting the data from a PDE's parent
reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show()
zoran: Don't print proc_dir_entry data in debug
drm: Constify drm_proc_list[]
drm: proc: Use minor->index to label things, not PDE->name
drm: proc: Use remove_proc_subtree()
hostap: proc: Use remove_proc_subtree()
dgrp: Clean up the use of procfs
ppc: Clean up rtas_flash driver somewhat
ppc: Clean up scanlog
proc: Supply an accessor to get the name in a proc_dir_entry struct
proc: Supply an accessor to get the process ID associated with some proc files
proc: Supply a function to remove a proc entry by PDE
proc: Make the PROC_I() and PDE() macros internal to procfs
proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h
arch/mips/mm/init.c | 1
arch/powerpc/kernel/proc_powerpc.c | 2
arch/powerpc/kernel/rtas_flash.c | 446 +++++++++++++----------------
arch/powerpc/platforms/pseries/reconfig.c | 2
arch/powerpc/platforms/pseries/scanlog.c | 29 +-
arch/s390/kernel/os_info.c | 1
arch/score/mm/init.c | 2
arch/sparc/kernel/sun4d_irq.c | 1
arch/x86/mm/init_64.c | 1
arch/x86/platform/efi/efi.c | 1
arch/x86/platform/efi/efi_64.c | 1
drivers/acpi/sbs.c | 21 -
drivers/char/ipmi/ipmi_msghandler.c | 2
drivers/firmware/efivars.c | 1
drivers/gpu/drm/drm_proc.c | 41 +--
drivers/gpu/drm/drm_stub.c | 2
drivers/media/pci/ttpci/av7110_ir.c | 2
drivers/media/pci/zoran/zoran_procfs.c | 2
drivers/message/i2o/i2o_proc.c | 8 -
drivers/misc/sgi-gru/gruprocfs.c | 2
drivers/mtd/mtdcore.c | 1
drivers/net/irda/vlsi_ir.c | 2
drivers/net/wireless/airo.c | 83 ++---
drivers/net/wireless/hostap/hostap_proc.c | 20 -
drivers/of/base.c | 11 -
drivers/pci/proc.c | 14 -
drivers/pps/clients/pps_parport.c | 1
drivers/scsi/megaraid.c | 6
drivers/staging/dgrp/dgrp_dpa_ops.c | 1
drivers/staging/dgrp/dgrp_mon_ops.c | 1
drivers/staging/dgrp/dgrp_net_ops.c | 2
drivers/staging/dgrp/dgrp_specproc.c | 83 ++---
drivers/staging/rtl8187se/r8180.h | 1
drivers/staging/rtl8187se/r8180_core.c | 28 +-
drivers/staging/rtl8192u/r8192U.h | 1
drivers/staging/rtl8192u/r8192U_core.c | 21 -
fs/namespace.c | 6
fs/proc/base.c | 14 +
fs/proc/fd.h | 5
fs/proc/generic.c | 71 +++--
fs/proc/inode.c | 9 -
fs/proc/internal.h | 346 +++++++++++++++-------
fs/proc/kcore.c | 2
fs/proc/namespaces.c | 17 +
fs/proc/proc_devtree.c | 2
fs/proc/proc_net.c | 4
fs/proc/self.c | 1
fs/proc/vmcore.c | 5
fs/reiserfs/procfs.c | 32 +-
include/drm/drmP.h | 5
include/linux/kcore.h | 38 ++
include/linux/of.h | 10 +
include/linux/proc_fs.h | 299 +++----------------
include/linux/proc_ns.h | 74 +++++
include/linux/signal.h | 5
include/linux/tty.h | 7
init/version.c | 2
ipc/msgutil.c | 2
ipc/namespace.c | 2
kernel/cgroup.c | 3
kernel/configs.c | 2
kernel/cpuset.c | 3
kernel/irq/proc.c | 6
kernel/nsproxy.c | 6
kernel/pid.c | 1
kernel/pid_namespace.c | 2
kernel/profile.c | 2
kernel/user.c | 2
kernel/user_namespace.c | 2
kernel/utsname.c | 2
net/8021q/vlanproc.c | 9 -
net/core/net_namespace.c | 7
net/core/pktgen.c | 6
net/ipv4/netfilter/ipt_CLUSTERIP.c | 4
net/ipv6/proc.c | 3
net/netfilter/xt_hashlimit.c | 6
net/netfilter/xt_recent.c | 3
sound/core/info.c | 21 -
78 files changed, 898 insertions(+), 994 deletions(-)
create mode 100644 include/linux/kcore.h
create mode 100644 include/linux/proc_ns.h
next reply other threads:[~2013-04-16 18:26 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 18:25 David Howells [this message]
2013-04-16 18:25 ` [PATCH 01/28] Include missing linux/slab.h inclusions [RFC] David Howells
2013-04-17 0:56 ` Greg KH
2013-04-16 18:25 ` [PATCH 02/28] Include missing linux/magic.h " David Howells
2013-04-16 18:26 ` [PATCH 03/28] proc: Split kcore bits from linux/procfs.h into linux/kcore.h [RFC] David Howells
2013-04-16 21:37 ` KOSAKI Motohiro
2013-04-16 22:07 ` David Howells
2013-04-16 22:13 ` KOSAKI Motohiro
2013-04-17 9:13 ` Ralf Baechle
2013-04-16 18:26 ` [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC] David Howells
2013-04-16 21:37 ` Mauro Carvalho Chehab
2013-04-18 16:42 ` Bjorn Helgaas
2013-04-25 15:22 ` Vasant Hegde
2013-04-16 18:26 ` [PATCH 05/28] proc: Uninline pid_delete_dentry() [RFC] David Howells
2013-04-16 18:26 ` [PATCH 06/28] proc: Move proc_fd() to fs/proc/fd.h [RFC] David Howells
2013-04-16 18:26 ` [PATCH 07/28] proc: Split the namespace stuff out into linux/proc_ns.h [RFC] David Howells
2013-04-16 18:26 ` [PATCH 08/28] proc: Move PDE_NET() to fs/proc/proc_net.c [RFC] David Howells
2013-04-16 18:26 ` [PATCH 09/28] proc: Move some bits from linux/proc_fs.h to linux/{of.h, signal.h, tty.h} [RFC] David Howells
2013-04-17 0:57 ` Greg Kroah-Hartman
2013-04-17 14:59 ` Grant Likely
2013-04-16 18:26 ` [PATCH 10/28] proc: Add proc_mkdir_data() [RFC] David Howells
2013-04-16 21:39 ` Mauro Carvalho Chehab
2013-04-17 0:58 ` Greg KH
2013-04-16 18:26 ` [PATCH 11/28] rtl8187se: Use a dir under /proc/net/r8180/ [RFC] David Howells
2013-04-17 0:59 ` Greg KH
2013-04-16 18:26 ` [PATCH 12/28] rtl8192u: Don't need to save device proc dir PDE [RFC] David Howells
2013-04-17 1:00 ` Greg KH
2013-04-16 18:26 ` [PATCH 13/28] airo: Use remove_proc_subtree() [RFC] David Howells
2013-04-16 18:26 ` [PATCH 14/28] proc: Supply an accessor for getting the data from a PDE's parent [RFC] David Howells
2013-04-17 1:01 ` Greg KH
2013-04-16 18:26 ` [PATCH 15/28] reiserfs: Don't access the proc_dir_entry in r_open(), r_start() r_show() [RFC] David Howells
2013-04-16 18:26 ` [PATCH 16/28] zoran: Don't print proc_dir_entry data in debug [RFC] David Howells
2013-04-16 21:32 ` Mauro Carvalho Chehab
2013-04-16 18:26 ` [PATCH 17/28] drm: Constify drm_proc_list[] [RFC] David Howells
2013-04-16 18:27 ` [PATCH 18/28] drm: proc: Use minor->index to label things, not PDE->name [RFC] David Howells
2013-04-16 18:27 ` [PATCH 19/28] drm: proc: Use remove_proc_subtree() [RFC] David Howells
2013-04-16 18:27 ` [PATCH 20/28] hostap: " David Howells
2013-04-16 18:27 ` [PATCH 21/28] dgrp: Clean up the use of procfs [RFC] David Howells
2013-04-17 1:02 ` Greg KH
2013-04-16 18:27 ` [PATCH 22/28] ppc: Clean up rtas_flash driver somewhat [RFC] David Howells
2013-04-25 14:33 ` Vasant Hegde
2013-04-16 18:27 ` [PATCH 23/28] ppc: Clean up scanlog [RFC] David Howells
2013-04-25 15:01 ` Vasant Hegde
2013-04-16 18:27 ` [PATCH 24/28] proc: Supply an accessor to get the name in a proc_dir_entry struct [RFC] David Howells
2013-04-16 22:20 ` Harald Welte
2013-04-16 18:27 ` [PATCH 25/28] proc: Supply an accessor to get the process ID associated with some proc files [RFC] David Howells
2013-04-17 1:53 ` Li Zefan
2013-04-18 18:39 ` Tejun Heo
2013-04-16 18:27 ` [PATCH 26/28] proc: Supply a function to remove a proc entry by PDE [RFC] David Howells
2013-04-17 15:03 ` Grant Likely
2013-04-18 16:41 ` Bjorn Helgaas
2013-04-18 20:34 ` David Howells
2013-04-21 22:01 ` Rafael J. Wysocki
2013-04-16 18:27 ` [PATCH 27/28] proc: Make the PROC_I() and PDE() macros internal to procfs [RFC] David Howells
2013-04-16 18:27 ` [PATCH 28/28] proc: Move non-public stuff from linux/proc_fs.h to fs/proc/internal.h [RFC] David Howells
2013-05-01 20:51 ` [PATCH 00/28] Privatise procfs internals [RFC] Geert Uytterhoeven
2013-05-03 20:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416182550.27773.89310.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).