From: Borislav Petkov <bp@alien8.de>
To: "Bryan O'Donoghue" <bryan.odonoghue.lkml@nexus-software.ie>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, x86@kernel.org,
fenghua.yu@intel.com
Subject: Re: [PATCH] x86: Add check for P5 to microcode_intel_early
Date: Fri, 19 Apr 2013 22:55:15 +0200 [thread overview]
Message-ID: <20130419205515.GA3075@pd.tnic> (raw)
In-Reply-To: <5171AA86.604@nexus-software.ie>
On Fri, Apr 19, 2013 at 09:35:18PM +0100, Bryan O'Donoghue wrote:
> Just returning X86_VENDOR_UNKNOWN - won't fix the bug though - after
> all MSR_IA32_UCODE_REV is also x86_family() >= 6
What are you talking about?
If you return X86_VENDOR_UNKNOWN from x86_vendor(),
load_ucode_intel_bsp() and load_ucode_intel_ap() won't be called and no
non-existing MSRs will be accessed.
Just filter out P5 and earlier. The code already does that for CPUs
which don't have CPUID.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-19 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:23 [PATCH] x86: Add check for P5 to microcode_intel_early Bryan O'Donoghue
2013-04-19 19:11 ` Borislav Petkov
2013-04-19 20:35 ` Bryan O'Donoghue
2013-04-19 20:55 ` Borislav Petkov [this message]
2013-04-19 21:25 ` Borislav Petkov
2013-04-19 21:44 ` Bryan O'Donoghue
2013-04-19 22:02 ` H. Peter Anvin
2013-04-19 23:13 ` H. Peter Anvin
2013-04-20 9:24 ` Bryan O'Donoghue
2013-04-20 15:52 ` H. Peter Anvin
2013-04-20 0:20 ` [tip:x86/urgent] x86, microcode: Verify the family before dispatching microcode patching tip-bot for H. Peter Anvin
2013-04-20 16:21 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419205515.GA3075@pd.tnic \
--to=bp@alien8.de \
--cc=bryan.odonoghue.lkml@nexus-software.ie \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).