From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
David Brown <davidb@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] char/misc patches for 3.10-rc1
Date: Mon, 29 Apr 2013 11:38:51 -0700 [thread overview]
Message-ID: <20130429183851.GA8106@kroah.com> (raw)
In-Reply-To: <CA+55aFz7bESS-T2_5vndVEzbk7ocmfEanBO+sviTSNekOLKRcg@mail.gmail.com>
On Mon, Apr 29, 2013 at 11:28:40AM -0700, Linus Torvalds wrote:
> On Mon, Apr 29, 2013 at 9:21 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Here's the big char / misc driver update for 3.10-rc1
>
> Ugh. What the f*ck is up with stuff like this:
>
> > drivers/ssbi/Kconfig | 16 +
> > drivers/ssbi/Makefile | 1 +
> > drivers/ssbi/ssbi.c | 379 ++++++++++++++
>
> Seriously? "ssbi" is such a major driver subsystem that it needs its
> own subdirectory at the top level?
>
> We can't just go adding random single drivers at the top level. Now,
> giving it a subdirectory of its own is certainly fine (there should be
> more drivers that decide "I'll put my files away from others", but it
> should be under drivers/misc/ or something. There's no way this is at
> the same level as "networking" or "pci".
It's a "bus" type, that has individual drivers connecting to it. I'm
pretty sure that David (now on to:) has a bunch more drivers queued up
for this directory, right David?
Now if we want to have a drivers/buses/ where we put these things,
that's fine with me, but so far, we seem to put new bus types directly
in drivers/
thanks,
greg k-h
next prev parent reply other threads:[~2013-04-29 18:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 16:21 [GIT PATCH] char/misc patches for 3.10-rc1 Greg KH
2013-04-29 18:28 ` Linus Torvalds
2013-04-29 18:38 ` Greg KH [this message]
2013-04-29 18:55 ` Linus Torvalds
2013-04-29 19:02 ` Linus Torvalds
2013-04-29 19:15 ` Linus Torvalds
2013-04-29 19:54 ` Arnd Bergmann
2013-04-29 20:12 ` Linus Torvalds
2013-04-29 20:50 ` Arnd Bergmann
2013-04-29 21:13 ` Linus Torvalds
2013-04-29 21:22 ` Arnd Bergmann
2013-05-01 16:12 ` Mark Brown
2013-04-29 21:08 ` David Brown
2013-04-29 21:16 ` Arnd Bergmann
2013-05-01 16:13 ` Mark Brown
2013-05-02 20:53 ` David Brown
2013-05-03 8:06 ` Mark Brown
2013-04-29 21:18 ` Linus Torvalds
2013-04-29 21:29 ` Arnd Bergmann
2013-04-29 22:00 ` MFD: move ssbi driver into drivers/mfd Arnd Bergmann
2013-04-29 22:10 ` Greg KH
2013-04-29 22:48 ` Nicolas Pitre
2013-04-30 0:00 ` David Brown
2013-04-30 10:18 ` Samuel Ortiz
2013-04-30 10:26 ` Arnd Bergmann
2013-05-16 9:49 ` Samuel Ortiz
2013-04-29 20:45 ` [GIT PATCH] char/misc patches for 3.10-rc1 Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429183851.GA8106@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).