From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759289Ab3D2XLL (ORCPT ); Mon, 29 Apr 2013 19:11:11 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:43064 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759231Ab3D2XLI (ORCPT ); Mon, 29 Apr 2013 19:11:08 -0400 Date: Mon, 29 Apr 2013 16:11:06 -0700 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Toshi Kani , ACPI Devel Maling List , LKML , isimatu.yasuaki@jp.fujitsu.com, vasilis.liaskovitis@profitbricks.com Subject: Re: [PATCH 2/3 RFC] Driver core: Use generic offline/online for CPU offline/online Message-ID: <20130429231106.GC1333@kroah.com> References: <1576321.HU0tZ4cGWk@vostro.rjw.lan> <5608485.T3GFgtNYov@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5608485.T3GFgtNYov@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2013 at 02:28:02PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Rework the CPU hotplug code in drivers/base/cpu.c to use the > generic offline/online support introduced previously instead of > its own CPU-specific code. > > For this purpose, modify cpu_subsys to provide offline and online > callbacks for CONFIG_HOTPLUG_CPU set and remove the code handling > the CPU-specific 'online' sysfs attribute. > > This modification is not supposed to change the user-observable > behavior of the kernel (i.e. the 'online' attribute will be present > in exactly the same place in sysfs and should trigger exactly the > same actions as before). > > Signed-off-by: Rafael J. Wysocki > --- > drivers/base/cpu.c | 62 ++++++++++++----------------------------------------- > 1 file changed, 15 insertions(+), 47 deletions(-) Very nice, I like reductions like this :) greg k-h