From: Pavel Machek <pavel@ucw.cz>
To: Zoran Markovic <zoran.markovic@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Colin Cross <ccross@android.com>,
Android Kernel Team <kernel-team@android.com>,
Todd Poynor <toddpoynor@google.com>, San Mehat <san@google.com>,
Benoit Goby <benoit@android.com>,
John Stultz <john.stultz@linaro.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Len Brown <len.brown@intel.com>
Subject: Re: [RFC PATCH] power: Add option to log time spent in suspend
Date: Wed, 1 May 2013 02:29:29 +0200 [thread overview]
Message-ID: <20130501002929.GA20042@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1367360914-23389-2-git-send-email-zoran.markovic@linaro.org>
Hi!
> From: Colin Cross <ccross@android.com>
>
> Below is a patch from android kernel that maintains a histogram of
> suspend times. Please review and provide feedback.
>
> Prints the time spent in suspend in the kernel log, and keeps statistics
> on the time spent in suspend in /sys/kernel/debug/suspend_time
>
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Colin Cross <ccross@android.com>
> Cc: Todd Poynor <toddpoynor@google.com>
> Cc: San Mehat <san@google.com>
> Cc: Benoit Goby <benoit@android.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: Colin Cross <ccross@android.com>
> Signed-off-by: Todd Poynor <toddpoynor@google.com>
> [zoran.markovic@linaro.org: Re-formatted suspend time table to better fit
> expected values, tweaked commit message]
> Signed-off-by: Zoran Markovic <zoran.markovic@linaro.org>
> +++ b/kernel/power/suspend_time.c
> @@ -0,0 +1,111 @@
> +/*
> + * debugfs file to track time spent in suspend
> + *
> + * Copyright (c) 2011, Google, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + */
> +
> +#include <linux/debugfs.h>
> +#include <linux/err.h>
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/seq_file.h>
> +#include <linux/syscore_ops.h>
> +#include <linux/time.h>
> +
> +static struct timespec suspend_time_before;
> +static unsigned int time_in_suspend_bins[32];
> +
> +#ifdef CONFIG_DEBUG_FS
> +static int suspend_time_debug_show(struct seq_file *s, void *data)
> +{
> + unsigned int bin;
> + seq_printf(s, " time (secs) count\n");
> + seq_printf(s, "------------------------------\n");
> + for (bin = 0; bin < 32; bin++) {
> + if (time_in_suspend_bins[bin] == 0)
> + continue;
> + seq_printf(s, "%10u - %-10u %4u\n",
> + bin ? 1 << (bin - 1) : 0, 1 << bin,
> + time_in_suspend_bins[bin]);
> + }
> + return 0;
> +}
> +
> +static int suspend_time_debug_open(struct inode *inode, struct file *file)
> +{
> + return single_open(file, suspend_time_debug_show, NULL);
> +}
Ok, whole new driver to get timing info... As we already have times in
printk, can't existing printks() get the same info? Maybe
Documentation/ file describing how to get that info from dmesg would
be enough?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-05-01 0:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 22:28 [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend Zoran Markovic
2013-04-30 22:28 ` [RFC PATCH] power: Add option to log time spent in suspend Zoran Markovic
2013-05-01 0:29 ` Pavel Machek [this message]
2013-05-01 3:29 ` Colin Cross
2013-05-02 12:27 ` Pavel Machek
2013-05-02 18:29 ` Colin Cross
2013-05-02 18:58 ` John Stultz
2013-05-02 19:11 ` Colin Cross
2013-04-30 23:30 ` [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend Greg Kroah-Hartman
2013-05-01 3:36 ` Colin Cross
2013-05-01 4:17 ` Greg Kroah-Hartman
2013-05-01 4:39 ` Colin Cross
[not found] ` <CAK7N6voYXxJKWDwSj5T9Y2fKK+Y5JqN9Wm8Qoffi9N7nRnsYhw@mail.gmail.com>
2013-05-01 5:14 ` Colin Cross
2013-05-01 0:30 ` Pavel Machek
2013-05-01 3:39 ` Colin Cross
2013-05-01 10:56 ` Pavel Machek
2013-05-01 16:10 ` Colin Cross
2013-05-01 16:24 ` Greg Kroah-Hartman
2013-05-02 12:30 ` Pavel Machek
2013-05-02 18:25 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501002929.GA20042@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=benoit@android.com \
--cc=ccross@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=san@google.com \
--cc=toddpoynor@google.com \
--cc=zoran.markovic@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).