From: Wolfram Sang <wsa@the-dreams.de>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: linux-i2c@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org, sjg@chromium.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Subject: Re: Fwd: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver
Date: Thu, 2 May 2013 13:27:21 +0200 [thread overview]
Message-ID: <20130502112721.GA7309@the-dreams.de> (raw)
In-Reply-To: <CAHfPSqC0E42+-oRfLoFCEe6CbV08fJQdkagvVYHaer4pJAU6pg@mail.gmail.com>
Hi,
> >> + - Samsung GPIO variant (deprecated):
> >> + - gpios: The order of the gpios should be the following: <SDA, SCL>.
> >> + The gpio specifier depends on the gpio controller.
> >
> > Huh? Why should we support a deprecated method with a new driver?
> >
This was left unanswered. I am curious.
> >> +Optional properties:
> >> + - samsung,hs-mode: Mode of operation, High speed or Fast speed mode. If not
> >> + specified, default value is 0.
> >> + - samsung,hs-clock-freq: Desired operating frequency in Hz of the bus.
> >> + If not specified, the default value in Hz is 100000.
> >> + - samsung,fs-clock-freq: Desired operarting frequency in Hz of the bus.
> >> + If not specified, the default value in Hz is 100000.
> >
> > NACK! We have a generic binding for defining the bus speed. And
> > shouldn't hs-mode be set depending on the bus speed?
Please use "clock-frequency" here, like other drivers do.
> >> + /* In auto mode the length of xfer cannot be 0 */
> >> + if (i2c->msg->len == 0)
> >> + i2c_auto_conf |= 0x1;
> >
> > So you send some byte then? Why not reject the message?
> This is to support the probing the devices (i2cdetect cases)
No! This is not a proper SMBUS_QUICK if you send a byte! If it doesn't
work without sending data, then your device does not support it. This is
not uncommon. Please check the smbus specs if you are unsure.
> >> + i2c->regs = of_iomap(np, 0);
> >
> > devm_ioremap_resource()
> This was a comment from Thomas on v1.
> https://lkml.org/lkml/2012/11/27/264
>
> Kindly, suggest me which one is more optimal in this case.
"Optimal" is difficult here, but devm_* has momentum and I prefer
consistency.
> Thanks for your valuable time and comments
You're welcome! Thanks for the submission.
Wolfram
next prev parent reply other threads:[~2013-05-02 11:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 13:00 [PATCH 0/3] i2c: Add High speed I2C controller driver for Exynos5 Naveen Krishna Chatradhi
2012-11-27 13:00 ` [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver Naveen Krishna Chatradhi
2012-11-27 13:23 ` Felipe Balbi
2012-11-27 13:34 ` Thomas Abraham
2012-11-28 4:23 ` Naveen Krishna Ch
2012-12-25 11:25 ` [PATCH 1/2] " Naveen Krishna Chatradhi
2012-12-25 11:25 ` [PATCH 2/2] i2c-exynos5: add debugfs support for registers Naveen Krishna Chatradhi
2012-12-27 22:57 ` Felipe Balbi
2012-12-27 22:59 ` Felipe Balbi
2012-12-27 22:57 ` [PATCH 1/2] i2c: exynos5: add High Speed I2C controller driver Felipe Balbi
2012-12-28 6:42 ` Naveen Krishna Ch
2012-12-28 11:27 ` [PATCH v3] " Naveen Krishna Chatradhi
2012-12-28 16:36 ` Naveen Krishna Ch
2013-01-15 6:23 ` Naveen Krishna Ch
2013-01-23 5:05 ` Naveen Krishna Ch
2013-02-01 15:54 ` [PATCH v4] " Naveen Krishna Chatradhi
2013-02-01 19:29 ` Wolfram Sang
2013-02-08 13:16 ` Grant Likely
2013-03-12 4:32 ` [PATCH] " Naveen Krishna Chatradhi
2013-03-12 13:13 ` Simon Glass
2013-03-20 16:26 ` Naveen Krishna Ch
2013-03-20 16:24 ` [RFC: PATCH v5] " Naveen Krishna Chatradhi
2013-03-25 11:52 ` Yuvaraj CD
2013-03-26 9:23 ` Wolfram Sang
2013-03-28 22:01 ` [PATCH v6] " Naveen Krishna Chatradhi
2013-03-28 23:40 ` Naveen Krishna Chatradhi
2013-04-05 4:52 ` [PATCH v7] " Naveen Krishna Chatradhi
2013-04-13 4:40 ` Naveen Krishna Ch
2013-04-16 10:29 ` Wolfram Sang
[not found] ` <CAHfPSqCe_VJMeH3oCDc0CfcmpawMj0hN7_b3ngHDFtDUsPJLsA@mail.gmail.com>
2013-05-01 23:19 ` Fwd: " Naveen Krishna Ch
2013-05-02 11:27 ` Wolfram Sang [this message]
2013-05-02 11:48 ` Naveen Krishna Ch
2013-05-07 2:50 ` [PATCH v8] " Naveen Krishna Chatradhi
2013-05-07 12:06 ` Sachin Kamat
2013-05-17 10:10 ` [PATCH v9] " Naveen Krishna Chatradhi
2013-05-23 6:29 ` Naveen Krishna Ch
2013-06-10 8:10 ` Naveen Krishna Ch
2013-06-10 14:38 ` Wolfram Sang
2013-06-19 10:48 ` [PATCH v10] " Naveen Krishna Chatradhi
2013-07-01 6:17 ` Wolfram Sang
2013-07-01 10:25 ` Tomasz Figa
2013-08-15 13:12 ` Wolfram Sang
2013-08-16 4:58 ` Naveen Krishna Ch
2013-08-16 7:05 ` Wolfram Sang
2013-08-21 9:24 ` [PATCH] " Naveen Krishna Chatradhi
2013-09-08 17:03 ` Wolfram Sang
2013-10-11 11:43 ` Naveen Krishna Ch
2013-10-16 5:30 ` [PATCH v12] " Naveen Krishna Chatradhi
2013-10-25 11:47 ` Naveen Krishna Ch
2013-11-01 11:35 ` Wolfram Sang
2012-11-27 13:00 ` [PATCH 2/3] ARM: exynos5: Add gate clocks for HS-I2C Naveen Krishna Chatradhi
2012-11-27 13:00 ` [PATCH 3/3] arm: exynos5: Add HS-I2C device tree platform information Naveen Krishna Chatradhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502112721.GA7309@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).