Re: [PATCH V2] ARM: bcm281xx: Add L2 support for Rev A2 chips

[Will Deacon <will.deacon@arm.com>]

On Fri, May 03, 2013 at 06:13:42PM +0100, Christian Daudt wrote:
> On 13-05-03 01:51 AM, Will Deacon wrote:
> > On Fri, May 03, 2013 at 01:57:33AM +0100, Christian Daudt wrote:
> >> Rev A2 SoCs have an unorthodox memory re-mapping and this needs
> >> to be reflected in the cache operations.
> >> This patch adds new outer cache functions for the l2x0 driver
> >> to support this SoC revision. It also adds a new compatible
> >> value for the cache to enable this functionality.
> >>
> >> Updates from V1:
> >> - remove section 1 altogether and note that in comments
> >> - simplify section selection caused by section 1 removal
> >> - BUG_ON just in case section 1 shows up
> > Looking much better now :)
> >
> >> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> >> index c465fac..d70e0ab 100644
> >> --- a/arch/arm/mm/cache-l2x0.c
> >> +++ b/arch/arm/mm/cache-l2x0.c
> >> @@ -523,6 +523,147 @@ static void aurora_flush_range(unsigned long start, unsigned long end)
> >>   	}
> >>   }
> >>   
> >> +/*
> >> + * For certain Broadcom SoCs, depending on the address range, different offsets
> >> + * need to be added to the address before passing it to L2 for
> >> + * invalidation/clean/flush
> >> + *
> >> + * Section Address Range              Offset        EMI
> >> + *   1     0x00000000 - 0x3FFFFFFF    0x80000000    VC
> >> + *   2     0x40000000 - 0xBFFFFFFF    0x40000000    SYS
> >> + *   3     0xC0000000 - 0xFFFFFFFF    0x80000000    VC
> > I don't think you answered last time (or I missed it) but where is the RAM
> > in the physical memory map for boards with this L2 controller? Do you
> > actually have 3GB@0x40000000?
> There can be up to 1G for VC and 1G for SYS. Usually that translates to 
> 0x80000000-0xFFFFFFFF

Ok, in which case:

  Reviewed-by: Will Deacon <will.deacon@arm.com>

Will