From: Guenter Roeck <linux@roeck-us.net>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 1/2] watchdog: xilinx: Fix driver header
Date: Sat, 1 Jun 2013 08:29:09 -0700 [thread overview]
Message-ID: <20130601152909.GB7751@roeck-us.net> (raw)
In-Reply-To: <b565740967bfa3b3fa867442634f524000c097f8.1369979787.git.michal.simek@xilinx.com>
On Fri, May 31, 2013 at 07:56:33AM +0200, Michal Simek wrote:
> - Remove reference for IP version
> - Fix header coding style
> - Remove notes which are visible from the code
> - Fix driver license according to header
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes in v2: None
>
> drivers/watchdog/of_xilinx_wdt.c | 30 ++++++++++--------------------
> 1 file changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 2761ddb..d4a35ab 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -1,23 +1,13 @@
> /*
> -* of_xilinx_wdt.c 1.01 A Watchdog Device Driver for Xilinx xps_timebase_wdt
> -*
> -* (C) Copyright 2011 (Alejandro Cabrera <aldaya@gmail.com>)
> -*
> -* -----------------------
> -*
> -* This program is free software; you can redistribute it and/or
> -* modify it under the terms of the GNU General Public License
> -* as published by the Free Software Foundation; either version
> -* 2 of the License, or (at your option) any later version.
> -*
> -* -----------------------
> -* 30-May-2011 Alejandro Cabrera <aldaya@gmail.com>
> -* - If "xlnx,wdt-enable-once" wasn't found on device tree the
> -* module will use CONFIG_WATCHDOG_NOWAYOUT
> -* - If the device tree parameters ("clock-frequency" and
> -* "xlnx,wdt-interval") wasn't found the driver won't
> -* know the wdt reset interval
> -*/
> + * Watchdog Device Driver for Xilinx axi/xps_timebase_wdt
> + *
> + * (C) Copyright 2011 (Alejandro Cabrera <aldaya@gmail.com>)
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> @@ -413,5 +403,5 @@ module_platform_driver(xwdt_driver);
>
> MODULE_AUTHOR("Alejandro Cabrera <aldaya@gmail.com>");
> MODULE_DESCRIPTION("Xilinx Watchdog driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
> --
> 1.8.2.3
>
next prev parent reply other threads:[~2013-06-01 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 5:56 [PATCH v2 0/2] Xilinx watchdog changes Michal Simek
2013-05-31 5:56 ` [PATCH v2 1/2] watchdog: xilinx: Fix driver header Michal Simek
2013-06-01 15:29 ` Guenter Roeck [this message]
2013-05-31 5:56 ` [PATCH v2 2/2] watchdog: xilinx: Setup the origin compatible string Michal Simek
2013-06-01 15:29 ` Guenter Roeck
2013-06-10 9:10 ` [PATCH v2 0/2] Xilinx watchdog changes Michal Simek
2013-06-26 13:00 ` Michal Simek
2013-06-27 19:21 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601152909.GB7751@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).