From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Alexander Gordeev <agordeev@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Jan Beulich <JBeulich@suse.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested
Date: Wed, 5 Jun 2013 23:28:41 +0200 [thread overview]
Message-ID: <20130605212841.GB5816@breakpoint.cc> (raw)
In-Reply-To: <CAErSpo5hJYhWpBfN6GpyPv-ViaYNXyyLtw96xcN59CtQjfZi6w@mail.gmail.com>
-Suresh
On Wed, Jun 05, 2013 at 03:09:34PM -0600, Bjorn Helgaas wrote:
>
> Alexander had an example device that advertised 16 vectors, but the
> driver knew that it could only generate 6. That's a case where we
> can't compute 'multiple' from 'nvec' (assuming the driver supplies
> 'nvec == 6'). If we just rounded up to compute 'multiple', I think
> we'd compute 8 instead of 16.
Sure, but as I said: the only place where 'multiple' is computed / written
it is doing the round-up thingy.
> > While nitpicking, 'nvec' might deserve a better comment than 'number of
> > messages' since it holds the number of allocated interrupts. :)
>
> I did change the name 'nvec' to 'nvec_used', which should help a bit.
> But I agree that it's still somewhat confusing.
>
> BTW, the patches actually in my tree are at
> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/alexander-msi
> (I tweaked this name and some comments slightly).
'nvec_used' is better the comment next to it is still wrong I think.
> Bjorn
Sebastian
next prev parent reply other threads:[~2013-06-05 21:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 9:05 [PATCH v3 -tip x86/apic 0/2] PCI/MSI: Allocate as many multiple-MSIs as requested Alexander Gordeev
2013-05-13 9:05 ` [PATCH v3 -tip x86/apic 1/2] " Alexander Gordeev
2013-05-28 9:50 ` Ingo Molnar
2013-06-05 20:56 ` Sebastian Andrzej Siewior
2013-06-05 21:09 ` Bjorn Helgaas
2013-06-05 21:28 ` Sebastian Andrzej Siewior [this message]
2013-06-06 8:30 ` Alexander Gordeev
2013-06-06 19:51 ` Sebastian Andrzej Siewior
2013-05-13 9:06 ` [PATCH v3 -tip x86/apic 2/2] x86/MSI: Conserve interrupt resources when using multiple-MSIs Alexander Gordeev
2013-06-05 20:08 ` Sebastian Andrzej Siewior
2013-05-28 21:51 [PATCH v3 -tip x86/apic 1/2] PCI/MSI: Allocate as many multiple-MSIs as requested Bjorn Helgaas
2013-05-29 8:36 ` Alexander Gordeev
2013-05-29 20:58 ` Bjorn Helgaas
2013-06-03 20:46 ` Bjorn Helgaas
2013-06-04 13:14 ` Alexander Gordeev
2013-06-05 17:18 ` Bjorn Helgaas
2013-06-05 18:33 ` Konrad Rzeszutek Wilk
2013-06-05 18:35 ` Bjorn Helgaas
2013-06-20 12:51 ` Joerg Roedel
2013-06-25 17:34 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605212841.GB5816@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=JBeulich@suse.com \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).