From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] tracing: more list_empty(perf_events) checks
Date: Tue, 18 Jun 2013 18:24:47 +0200 [thread overview]
Message-ID: <20130618162447.GA5877@redhat.com> (raw)
In-Reply-To: <1371570100.18733.30.camel@gandalf.local.home>
On 06/18, Steven Rostedt wrote:
>
> On Tue, 2013-06-18 at 16:46 +0200, Oleg Nesterov wrote:
> >
> > Perhaps you are trying to say that this patch needs more work...
> >
> > Just because it can't be compiled? Pedant.
>
> No, just because when I first looked at it, I didn't think it would,
And your intuition was correct.
It can't be compiled if you also change TRACE_EVENT(sched_stat_runtime)
to use TP_perf_arg(__count, runtime). Hopefully this can be fixed by
- TRACE_EVENT(...)
+ DECLARE_EVENT_CLASS(...)
+ DEFINE_EVENT(...)
Oleg.
next prev parent reply other threads:[~2013-06-18 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 17:01 [PATCH 0/3] tracing: more list_empty(perf_events) checks Oleg Nesterov
2013-06-17 17:02 ` [PATCH 1/3] tracing/function: Avoid perf_trace_buf_*() if event_function.perf_events is empty Oleg Nesterov
2013-06-17 17:02 ` [PATCH 2/3] tracing/syscall: Avoid perf_trace_buf_*() if sys_data->perf_events " Oleg Nesterov
2013-06-17 17:02 ` [PATCH 3/3] tracing/perf: Move the PERF_MAX_TRACE_SIZE check into perf_trace_buf_prepare() Oleg Nesterov
2013-06-17 20:18 ` [PATCH 0/3] tracing: more list_empty(perf_events) checks Oleg Nesterov
2013-06-17 21:27 ` Steven Rostedt
2013-06-18 14:46 ` Oleg Nesterov
2013-06-18 15:41 ` Steven Rostedt
2013-06-18 16:24 ` Oleg Nesterov [this message]
2013-07-18 3:00 ` Steven Rostedt
2013-07-18 9:42 ` Peter Zijlstra
2013-07-18 14:39 ` Steven Rostedt
2013-07-18 15:44 ` Oleg Nesterov
2013-07-18 15:53 ` Steven Rostedt
2013-07-18 16:11 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618162447.GA5877@redhat.com \
--to=oleg@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).