From: Arnd Bergmann <arnd@arndb.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"'Grant Likely'" <grant.likely@secretlab.ca>,
"'Andrew Murray'" <andrew.murray@arm.com>,
"'Thomas Petazzoni'" <thomas.petazzoni@free-electrons.com>,
"'Thierry Reding'" <thierry.reding@avionic-design.de>,
"'Jason Gunthorpe'" <jgunthorpe@obsidianresearch.com>,
"'Surendranath Gurivireddy Balla'" <suren.reddy@samsung.com>,
"'Siva Reddy Kallam'" <siva.kallam@samsung.com>,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Tomasz Figa'" <t.figa@samsung.com>,
"'Pratyush Anand'" <pratyush.anand@st.com>,
"'Mohit KUMAR'" <Mohit.KUMAR@st.com>
Subject: Re: [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos
Date: Thu, 20 Jun 2013 15:20:48 +0200 [thread overview]
Message-ID: <201306201520.49212.arnd@arndb.de> (raw)
In-Reply-To: <00db01ce6db3$7f9a3830$7ecea890$@samsung.com>
On Thursday 20 June 2013, Jingoo Han wrote:
> diff --git a/Documentation/devicetree/bindings/pci/exynos-pcie.txt b/Documentation/devicetree/bindings/pci/exynos-pcie.txt
> new file mode 100644
> index 0000000..f71d835
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/exynos-pcie.txt
> @@ -0,0 +1,73 @@
> +* Samsung Exynos PCIe interface
Please adapt the name of the binding as well, and name it snps-dwc-pcie.txt
for instance, to match the change in the driver and in the binding.
> +Required properties:
> +-compatible: should contain "snps,dwc-pcie" to identify the
> + core, plus an identifier for the specific instance, such
> + as "samsung,exynos5440-pcie".
Thanks for changing it here.
> +
> + pcie@290000 {
> + compatible = "samsung,exynos5440-pcie";
> + reg = <0x290000 0x1000
> + 0x270000 0x1000
> + 0x271000 0x40>;
but please also change the example and the .dts files to match.
It should say here
compatible = "samsung,exynos5440-pcie", "snps,dwc-pcie";
as now required by the binding.
Arnd
prev parent reply other threads:[~2013-06-20 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 12:41 [PATCH V8 1/4] pci: Add PCIe driver for Samsung Exynos Jingoo Han
2013-06-20 13:20 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306201520.49212.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Mohit.KUMAR@st.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=siva.kallam@samsung.com \
--cc=suren.reddy@samsung.com \
--cc=t.figa@samsung.com \
--cc=thierry.reding@avionic-design.de \
--cc=thomas.abraham@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).