linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: George Spelvin <linux@horizon.com>,
	bp@alien8.de, kaber@trash.net, linux-kernel@vger.kernel.org,
	netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: v3.10-rc7 oops soon after boot
Date: Mon, 24 Jun 2013 17:10:31 +0200	[thread overview]
Message-ID: <20130624151031.GB3917@localhost> (raw)
In-Reply-To: <20130624113441.GA2583@localhost>

On Mon, Jun 24, 2013 at 01:34:41PM +0200, Pablo Neira Ayuso wrote:
> On Mon, Jun 24, 2013 at 05:52:08PM +0800, Gao feng wrote:
> > On 06/24/2013 05:41 PM, George Spelvin wrote:
> > >> Please try the patch below,
> > >> I think this bug is introduced by me :(
> > >>
> > >> Thanks!
> > > 
> > > Well, you changed it, but it still crashes.
> > > 
> > > It's now at del_timer+0x9/0x58, with the code being:
> > 
> > This one should work.
> > 
> > Thanks for your quickly reply.
> 
> I managed to crash it using a group != 1 (default) and enabling
> batching:
> 
> iptables -I INPUT -j ULOG --ulog-nlgroup 2 --ulog-qthresh 50
> 
> It seems ulog->nlgroup[i] is always left unset.
> 
> I have mangled your patch, find it attached.

> From 79da8ea854c06ca9320decbb2f9d2e8d25b2f7e5 Mon Sep 17 00:00:00 2001
> From: Gao feng <gaofeng@cn.fujitsu.com>
> Date: Mon, 24 Jun 2013 17:04:02 +0800
> Subject: [PATCH] netfilter: ipt_ULOG: fix incorrect setting of ulog timer
> 
> The parameter of setup_timer should be &ulog->nlgroup[i].
> the incorrect parameter will cause kernel panic in
> ulog_timer.
> 
> Bug introducted in commit 355430671ad93546b34b4e91bdf720f3a704efa4
> "netfilter: ipt_ULOG: add net namespace support for ipt_ULOG"
> 
> ebt_ULOG doesn't have this problem.
> 
> Reported-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

I have applied the patch that I sent you.

  reply	other threads:[~2013-06-24 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24  6:49 v3.10-rc7 oops soon after boot George Spelvin
2013-06-24  7:03 ` George Spelvin
2013-06-24  7:33 ` Borislav Petkov
2013-06-24  8:47   ` George Spelvin
2013-06-24  9:12     ` Gao feng
2013-06-24  9:41       ` George Spelvin
2013-06-24  9:52         ` Gao feng
2013-06-24 10:01           ` George Spelvin
2013-06-24 11:34           ` Pablo Neira Ayuso
2013-06-24 15:10             ` Pablo Neira Ayuso [this message]
2013-06-24 16:13               ` Borislav Petkov
2013-06-24 22:17                 ` George Spelvin
2013-06-24 22:34                   ` Borislav Petkov
2013-06-25  1:36                   ` Gao feng
2013-06-25  6:17             ` Gao feng
2013-06-26  6:28             ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624151031.GB3917@localhost \
    --to=pablo@netfilter.org \
    --cc=bp@alien8.de \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).