linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Shin <jacob.shin@amd.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Tim Gardner <tim.gardner@canonical.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	LKML <linux-kernel@vger.kernel.org>, <cpufreq@vger.kernel.org>,
	<linux-pm@vger.kernel.org>
Subject: Re: od_set_powersave_bias: NULL pointer dereference
Date: Wed, 26 Jun 2013 09:35:55 -0500	[thread overview]
Message-ID: <20130626143555.GA2989@jshin-Toonie> (raw)
In-Reply-To: <CAKohpom_jHQeR2FKFS3-RkxpPrJvekw8pDb-qnApnzu-VqreBQ@mail.gmail.com>

On Wed, Jun 26, 2013 at 08:02:29PM +0530, Viresh Kumar wrote:
> On 26 June 2013 19:58, Jacob Shin <jacob.shin@amd.com> wrote:
> > On Wed, Jun 26, 2013 at 12:18:27PM +0530, Viresh Kumar wrote:
> 
> >> I am not sure if this is enough. What if we had ondemand as the
> >> governor initially, then we changed it to something else. Now also
> >> cur_policy contains a address and isn't zero.
> >
> > Right, so we check below ..
> >
> >>
> >> >                 cpumask_or(&done, &done, policy->cpus);
> >> > +
> >> > +               if (policy->governor != &cpufreq_gov_ondemand)
> >> > +                       continue;
> >
> > This should catch that case no ?
> 
> Policy might be freed and reallocated by then. And so doing
> policy->governor is dangerous.

Hm . any hints on how to check for if ondemand is running on this CPU
or not ? I'm not sure what the best way to handle this is ..

Thanks,


  reply	other threads:[~2013-06-26 14:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 16:59 od_set_powersave_bias: NULL pointer dereference Tim Gardner
2013-06-25  6:56 ` Viresh Kumar
2013-06-25 16:19   ` Jacob Shin
2013-06-25 18:41     ` Tim Gardner
2013-06-25 22:39       ` Rafael J. Wysocki
2013-06-26  6:48     ` Viresh Kumar
2013-06-26 14:28       ` Jacob Shin
2013-06-26 14:32         ` Viresh Kumar
2013-06-26 14:35           ` Jacob Shin [this message]
2013-06-26 17:57           ` Jacob Shin
2013-06-27  7:02             ` Viresh Kumar
2013-06-27 14:55               ` Jacob Shin
2013-06-27 15:09                 ` Viresh Kumar
2013-06-27 15:20                   ` Viresh Kumar
2013-06-27 16:22                     ` Jacob Shin
2013-06-27 16:23                       ` Viresh Kumar
2013-06-27 15:21                   ` Jacob Shin
2013-06-27 15:25                     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130626143555.GA2989@jshin-Toonie \
    --to=jacob.shin@amd.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tim.gardner@canonical.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).