From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 3/8] vfio: add external user support
Date: Thu, 27 Jun 2013 16:59:29 +1000 [thread overview]
Message-ID: <20130627165929.3828c261c957845a549ad95b@canb.auug.org.au> (raw)
In-Reply-To: <1372309356-28320-4-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Hi Alexy,
On Thu, 27 Jun 2013 15:02:31 +1000 Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>
> +/* Allows an external user (for example, KVM) to unlock an IOMMU group */
> +static void vfio_group_del_external_user(struct file *filep)
> +{
> + struct vfio_group *group = filep->private_data;
> +
> + BUG_ON(filep->f_op != &vfio_group_fops);
We usually reserve BUG_ON for situations where there is no way to
continue running or continuing will corrupt the running kernel. Maybe
WARN_ON() and return?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-27 6:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 5:02 [PATCH 0/8 v4] KVM: PPC: IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 1/8] KVM: PPC: reserve a capability number for multitce support Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO Alexey Kardashevskiy
2013-07-09 15:35 ` Alexander Graf
2013-07-09 23:35 ` Alexey Kardashevskiy
2013-07-10 10:27 ` Alexander Graf
2013-07-10 14:17 ` Alexey Kardashevskiy
2013-07-10 15:00 ` Alexander Graf
2013-06-27 5:02 ` [PATCH 3/8] vfio: add external user support Alexey Kardashevskiy
2013-06-27 6:47 ` Stephen Rothwell
2013-06-27 7:14 ` [PATCH v2] " Alexey Kardashevskiy
2013-06-27 7:50 ` Stephen Rothwell
2013-06-27 15:44 ` Alex Williamson
2013-06-27 22:57 ` Alexey Kardashevskiy
2013-06-28 0:41 ` Alex Williamson
2013-06-28 1:38 ` Alexey Kardashevskiy
2013-06-28 2:37 ` Alex Williamson
2013-06-28 3:10 ` Alexey Kardashevskiy
2013-06-27 6:59 ` Stephen Rothwell [this message]
2013-06-27 9:42 ` [PATCH 3/8] " Benjamin Herrenschmidt
2013-06-27 10:48 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 4/8] hashtable: add hash_for_each_possible_rcu_notrace() Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 5/8] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 7/8] KVM: PPC: Add support for IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 8/8] KVM: PPC: Add hugepage " Alexey Kardashevskiy
2013-06-27 18:39 ` Scott Wood
2013-07-06 15:06 [PATCH 0/8 v5] KVM: PPC: " Alexey Kardashevskiy
2013-07-06 15:07 ` [PATCH 3/8] vfio: add external user support Alexey Kardashevskiy
2013-07-08 21:52 ` Alex Williamson
2013-07-09 5:40 ` Alexey Kardashevskiy
2013-07-09 14:08 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627165929.3828c261c957845a549ad95b@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).