From: Kevin Strasser <kevin.strasser@linux.intel.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Kevin Strasser <strassek@engr.orst.edu>,
Darren Hart <dvhart@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Michael Brunner <Michael.Brunner@kontron.com>,
Michael Brunner <mibru@gmx.de>, Chris Healy <chealy@imsco-us.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dirk Hohndel <Dirk.Hohndel@intel.com>,
Wolfram Sang <wsa@the-dreams.de>, Ben Dooks <ben-linux@fluff.org>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver
Date: Thu, 27 Jun 2013 15:05:56 -0700 [thread overview]
Message-ID: <20130627220556.GB16090@wrk> (raw)
In-Reply-To: <20130627214705.GA26192@zurbaran>
Hi Samuel,
On Thu, Jun 27, 2013 at 11:47:05PM +0200, Samuel Ortiz wrote:
> Hi Kevin,
>
> On Thu, Jun 27, 2013 at 11:23:15AM -0700, Kevin Strasser wrote:
> > Hi Wim,
> >
> > This driver hasn't received any further feedback. Are you ready to take it
> > into watchdog-next, or do you still need to review it?
> I applied the watchdog patch to mfd-next and got the following warning:
>
> CC [M] drivers/watchdog/kempld_wdt.o
> drivers/watchdog/kempld_wdt.c: In function ‘kempld_wdt_suspend’:
> drivers/watchdog/kempld_wdt.c:538:3: warning: passing argument 1 of
> ‘kempld_wdt_stop’ from incompatible pointer type [enabled by default]
> drivers/watchdog/kempld_wdt.c:313:12: note: expected ‘struct
> watchdog_device *’ but argument is of type ‘struct platform_device *’
>
> I fixed it up, but I'd appreciate if you could double check that
> kempld_wdt_suspend() is ok.
Ah, yes you made the appropriate change. This used to be a call to
kempld_wdt_shutdown, which I changed to kempld_wdt_stop to avoid the
pointless redirection. Somehow I forgot to convert the argument.
Thanks,
Kevin
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
next prev parent reply other threads:[~2013-06-27 22:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:15 [PATCH 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-04-08 17:15 ` [PATCH 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-04-10 17:02 ` Guenter Roeck
2013-04-16 9:53 ` Wolfram Sang
2013-04-08 17:15 ` [PATCH 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-04-09 8:46 ` Linus Walleij
2013-04-09 16:41 ` Guenter Roeck
2013-04-10 20:06 ` Linus Walleij
2013-04-10 20:45 ` Linus Walleij
2013-04-12 11:09 ` Michael Brunner
2013-04-12 22:05 ` Linus Walleij
2013-04-08 17:15 ` [PATCH 4/4] watchdog: Kontron PLD watchdog timer Kevin Strasser
2013-04-10 16:47 ` Guenter Roeck
2013-04-10 16:57 ` Kevin Strasser
2013-05-26 14:38 ` Wim Van Sebroeck
2013-04-13 20:38 ` [PATCH 1/4] mfd: Kontron PLD mfd driver Thomas Gleixner
2013-04-18 4:19 ` Guenter Roeck
2013-04-18 4:40 ` Joe Perches
2013-04-18 13:35 ` Guenter Roeck
2013-04-18 16:42 ` Joe Perches
2013-04-18 18:40 ` Guenter Roeck
2013-06-18 21:04 ` [PATCH v2 0/4] Kontron PLD drivers Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-06-19 8:40 ` Linus Walleij
2013-06-19 9:11 ` Samuel Ortiz
2013-06-19 9:48 ` Mark Brown
2013-06-19 9:12 ` Thomas Gleixner
2013-06-19 18:03 ` Kevin Strasser
2013-06-19 20:35 ` Guenter Roeck
2013-06-18 21:04 ` [PATCH v2 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-06-19 8:36 ` Linus Walleij
2013-06-27 22:14 ` Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 4/4] watchdog: Kontron PLD watchdog timer driver Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 0/4] Kontron PLD drivers Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-07-01 6:40 ` Wolfram Sang
2013-06-24 4:00 ` [PATCH v3 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-07-21 14:31 ` Linus Walleij
2013-06-24 4:00 ` [PATCH v3 4/4] watchdog: Kontron PLD watchdog timer driver Kevin Strasser
2013-06-27 18:23 ` Kevin Strasser
2013-06-27 21:47 ` Samuel Ortiz
2013-06-27 22:05 ` Kevin Strasser [this message]
2013-06-24 12:06 ` [PATCH v3 0/4] Kontron PLD drivers Samuel Ortiz
2013-06-24 16:09 ` Wolfram Sang
2013-06-27 20:34 ` Wim Van Sebroeck
2013-06-27 21:48 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627220556.GB16090@wrk \
--to=kevin.strasser@linux.intel.com \
--cc=Dirk.Hohndel@intel.com \
--cc=Michael.Brunner@kontron.com \
--cc=ben-linux@fluff.org \
--cc=chealy@imsco-us.com \
--cc=dvhart@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mibru@gmx.de \
--cc=sameo@linux.intel.com \
--cc=strassek@engr.orst.edu \
--cc=tglx@linutronix.de \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).