From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V2 06/15] perf tools: fix parse_events_terms() freeing local variable on error path
Date: Fri, 28 Jun 2013 15:57:36 +0200 [thread overview]
Message-ID: <20130628135736.GA29993@krava.brq.redhat.com> (raw)
In-Reply-To: <51CD92A3.5000202@gmail.com>
On Fri, Jun 28, 2013 at 07:41:55AM -0600, David Ahern wrote:
> On 6/28/13 12:32 AM, Adrian Hunter wrote:
>
> >>Seems like you can just fix parse_events__free_terms to do the right thing
> >>and not call free(terms) -- ie., no need for a separate "only" function.
> >> From there only test_term() needs to do the free(terms) and since it mallocs
> >>the memory there it is nicely symmetrical.
> >
> >There are 2 more calls to parse_events__free_terms in util/parse-events.y
> >
>
> Right and both look like stack case uses. I don't see the need for
> __free_terms to free the list so no need for an _only version.
there's also another one in pmu_alias_terms function
which uses on stack list_head
jirka
next prev parent reply other threads:[~2013-06-28 14:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 7:54 [PATCH V2 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 01/15] perf tools: remove unused parameter Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 02/15] perf tools: fix missing tool parameter Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 03/15] perf tools: fix missing 'finished_round' Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 04/15] perf tools: fix parse_events_terms() segfault on error path Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 05/15] perf tools: fix new_term() missing free " Adrian Hunter
2013-06-27 7:54 ` [PATCH V2 06/15] perf tools: fix parse_events_terms() freeing local variable " Adrian Hunter
2013-06-27 16:13 ` David Ahern
2013-06-28 6:32 ` Adrian Hunter
2013-06-28 13:41 ` David Ahern
2013-06-28 13:57 ` Jiri Olsa [this message]
2013-06-27 7:54 ` [PATCH V2 07/15] perf tools: add const specifier to perf_pmu__find name parameter Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 08/15] perf tools: tidy duplicated munmap code Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 09/15] perf tools: validate perf event header size Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 10/15] perf tools: add debug prints Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 11/15] perf tools: fix symbol_conf.nr_events Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 12/15] perf tools: allow non-matching sample types Adrian Hunter
2013-06-27 16:39 ` David Ahern
2013-07-01 9:32 ` Adrian Hunter
2013-07-01 18:53 ` David Ahern
2013-07-01 19:10 ` Stephane Eranian
2013-07-02 6:58 ` Adrian Hunter
2013-07-03 6:40 ` Stephane Eranian
2013-07-02 7:09 ` Adrian Hunter
2013-07-03 6:44 ` Stephane Eranian
2013-08-26 18:54 ` Arnaldo Carvalho de Melo
2013-06-27 7:55 ` [PATCH V2 13/15] perf tools: struct thread has a tid not a pid Adrian Hunter
2013-06-27 7:55 ` [PATCH V2 14/15] perf tools: add pid to struct thread Adrian Hunter
2013-06-27 16:52 ` David Ahern
2013-06-27 7:55 ` [PATCH V2 15/15] perf tools: fix ppid in thread__fork() Adrian Hunter
2013-06-27 16:57 ` David Ahern
2013-06-28 6:47 ` Adrian Hunter
2013-06-28 13:46 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628135736.GA29993@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).