From: Andi Kleen <andi@firstfloor.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] pci: Avoid unnecessary calls to work_on_cpu
Date: Mon, 8 Jul 2013 06:37:03 +0200 [thread overview]
Message-ID: <20130708043703.GT6123@two.firstfloor.org> (raw)
In-Reply-To: <87wqp1esff.fsf@rustcorp.com.au>
> > But Rusty added this (in 873392ca51), and he knows way more about this
> > stuff than I do.
>
> Actually, I just stopped the code from playing cpumask games, which is
> what it used to do.
You're right the numa_node_id() check ptimization is not 100% safe on preempt
kernels and should be probably removed. Also I agree it would probably
make sense to move it up to the generic device layer (although I'm not
sure that other bus types really care that much about NUMA locality)
None of it seems to be a fatal problem though, so it boils down to
"if someone cares enough to write a patch"
-Andi
prev parent reply other threads:[~2013-07-08 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 20:05 [PATCH] pci: Avoid unnecessary calls to work_on_cpu Alexander Duyck
2013-07-05 23:36 ` Bjorn Helgaas
2013-07-06 0:29 ` Benjamin Herrenschmidt
2013-07-08 1:44 ` Rusty Russell
2013-07-08 4:37 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130708043703.GT6123@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).