From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120Ab3GOSWi (ORCPT ); Mon, 15 Jul 2013 14:22:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098Ab3GOSWh (ORCPT ); Mon, 15 Jul 2013 14:22:37 -0400 Date: Mon, 15 Jul 2013 20:16:59 +0200 From: Oleg Nesterov To: Masami Hiramatsu Cc: Steven Rostedt , Peter Zijlstra , Frederic Weisbecker , linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Andrew Morton , jovi.zhangwei@huawei.com, Jiri Olsa , Srikar Dronamraju Subject: Re: [RFC PATCH V2] tracing: Check f_dentry before accessing event_file/call in inode->i_private Message-ID: <20130715181659.GA18505@redhat.com> References: <20130705003223.GA4981@redhat.com> <20130709075519.2583.96462.stgit@mhiramat-M0-7522> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130709075519.2583.96462.stgit@mhiramat-M0-7522> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09, Masami Hiramatsu wrote: > > To avoid this, when opening events/*/*/enable, we have to ensure > the dentry of the file is not unlinked yet, under event_mutex > is locked. Probably this can work, but I am starting to think that this ref count becomes toooooo complex.... Could you please look at the draft patch I sent in another email? Oleg.