From: Lukasz Majewski <l.majewski@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Lukasz Majewski <l.majewski@majess.pl>,
linux-kernel <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
durgadoss.r@intel.com,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH v6 2/8] cpufreq: Add boost frequency support in core
Date: Fri, 26 Jul 2013 10:33:21 +0200 [thread overview]
Message-ID: <20130726103321.21238bbb@amdc308.digital.local> (raw)
In-Reply-To: <CAKohpom9QHf+XBYQcajv4tni4_KA2x+Y3BAXWhZkdCFnZxp3XA@mail.gmail.com>
On Fri, 26 Jul 2013 12:47:15 +0530 Viresh Kumar wrote,
> On 25 July 2013 22:03, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>
> > /*********************************************************************
> > + *
> > BOOST *
> > +
> > *********************************************************************/
> > +static int cpufreq_boost_set_sw(int state) +{
> > + struct cpufreq_frequency_table *freq_table;
> > + struct cpufreq_policy *policy;
> > + int ret = -EINVAL;
> > +
> > + list_for_each_entry(policy, &cpufreq_policy_list,
> > policy_list) {
> > + freq_table =
> > cpufreq_frequency_get_table(policy->cpu);
> > + if (freq_table) {
> > + ret =
> > cpufreq_frequency_table_cpuinfo(policy,
> > + freq_table);
> > + if (!ret) {
> > + policy->user_policy.max =
> > policy->max;
> > + __cpufreq_governor(policy,
> > CPUFREQ_GOV_LIMITS);
> > + }
> > + }
> > + }
> > +
> > + return ret;
> > +}
> > +
> > +int cpufreq_boost_trigger_state(int state)
> > +{
> > + unsigned long flags;
> > + int ret = 0;
> > +
> > + if (cpufreq_driver->boost_enabled == state)
> > + return 0;
> > +
> > + write_lock_irqsave(&cpufreq_driver_lock, flags);
> > + cpufreq_driver->boost_enabled = state;
> > + write_unlock_irqrestore(&cpufreq_driver_lock, flags);
^^^^^^^^^^^^^^^^^^^^ [*]
>
> Not sure if we should leave the lock at this point of time, as we
> haven't enabled boost until now.
The problem here is with the cpufreq_driver->set_boost() call.
I tried to avoid acquiring lock at one function and release it at
another (in this case cpufreq_boost_set_sw), especially since the
__cpufreq_governor() acquires its own lock - good place for deadlock.
Is it OK for you to grab lock at one function
(cpufreq_boost_trigger_state()) and then at other function
(cpufreq_boost_set_sw) release it before calling __cpufreq_governor()
and grab it again after its completion?
>
> If somebody tries to use this variable at this point of time, then
> it would get the wrong information about it.
>
> > + ret = cpufreq_driver->set_boost(state);
> > + if (ret) {
> > + write_lock_irqsave(&cpufreq_driver_lock, flags);
> > + cpufreq_driver->boost_enabled = 0;
>
> should be:
> cpufreq_driver->boost_enabled = !state;
For me = 0 (or = false) is more readable.
If you wish, I will change it to = !state.
>
> > + write_unlock_irqrestore(&cpufreq_driver_lock,
> > flags); +
> > + pr_err("%s: BOOST cannot %s\n", __func__,
>
> s/BOOST cannot %s/Cannot %s BOOST
Ok.
>
> > + state ? "enabled" : "disabled");
> > + }
> > +
> > + return ret;
> > +}
> > +
> > +int cpufreq_boost_supported(void)
> > +{
> > + if (cpufreq_driver)
>
> This routine is always called from places where cpufreq_driver
> can't be NULL..
It is also called from thermal. And it happens that thermal is
initialized earlier.
Then "NULL pointer dereference" happens.
>
> --contd--
>
> > + return cpufreq_driver->boost_supported;
> > +
> > + return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(cpufreq_boost_supported);
> > +
> > +int cpufreq_boost_enabled(void)
> > +{
> > + return cpufreq_driver->boost_enabled;
^^^^^^^^^^^^^^ [1]
>
> And if above check is necessary, then don't you need to check
> it here as well?
Because on thermal I check first if cpufreq_boost_supported() is true.
If boost is not supported then check for cpufreq_boost_enabled() is not
performed.
In my opinion at [1] we don't need the if (cpufreq_driver) check.
But it is up to you to decide.
>
> > +}
> > +EXPORT_SYMBOL_GPL(cpufreq_boost_enabled);
> > +
> > +/*********************************************************************
> > * REGISTER / UNREGISTER CPUFREQ
> > DRIVER *
> > *********************************************************************/
> >
> > @@ -2008,9 +2099,25 @@ int cpufreq_register_driver(struct
> > cpufreq_driver *driver_data) cpufreq_driver = driver_data;
> > write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> >
> > + if (cpufreq_boost_supported()) {
> > + /*
> > + * Check if boost driver provides function to
> > enable boost -
>
> s/boost driver/driver
Ok.
>
> > + * if not, use cpufreq_boost_set_sw as default
> > + */
> > + if (!cpufreq_driver->set_boost)
> > + cpufreq_driver->set_boost =
> > cpufreq_boost_set_sw; +
> > + ret = cpufreq_sysfs_create_file(&(boost.attr));
>
> You don't need braces around boost.attr.
Ok.
>
> > + if (ret) {
> > + pr_err("%s: cannot register global BOOST
> > sysfs file\n",
> > + __func__);
> > + goto err_null_driver;
> > + }
> > + }
> > +
> > ret = subsys_interface_register(&cpufreq_interface);
> > if (ret)
> > - goto err_null_driver;
> > + goto err_boost_unreg;
> >
> > if (!(cpufreq_driver->flags & CPUFREQ_STICKY)) {
> > int i;
> > @@ -2037,6 +2144,9 @@ int cpufreq_register_driver(struct
> > cpufreq_driver *driver_data) return 0;
> > err_if_unreg:
> > subsys_interface_unregister(&cpufreq_interface);
> > +err_boost_unreg:
> > + if (cpufreq_boost_supported())
> > + cpufreq_sysfs_remove_file(&(boost.attr));
>
> same here.
Ok.
>
> > err_null_driver:
> > write_lock_irqsave(&cpufreq_driver_lock, flags);
> > cpufreq_driver = NULL;
> > @@ -2063,6 +2173,9 @@ int cpufreq_unregister_driver(struct
> > cpufreq_driver *driver) pr_debug("unregistering driver %s\n",
> > driver->name);
> >
> > subsys_interface_unregister(&cpufreq_interface);
> > + if (cpufreq_boost_supported())
> > + cpufreq_sysfs_remove_file(&(boost.attr));
>
> here too.
Ok.
>
> > +
> > unregister_hotcpu_notifier(&cpufreq_cpu_notifier);
> >
> > write_lock_irqsave(&cpufreq_driver_lock, flags);
>
> > +static ssize_t scaling_available_frequencies_show(struct
> > cpufreq_policy *policy,
> > + char *buf)
> > +{
> > + return show_available_freqs(policy, buf, 0);
>
> s/0/false
Ok.
>
> > +}
>
> > +static ssize_t scaling_boost_frequencies_show(struct
> > cpufreq_policy *policy,
> > + char *buf)
> > +{
> > + return show_available_freqs(policy, buf, 1);
>
> s/1/true
Ok.
>
> > +}
>
> Looks good mostly.. We Should be to get it in 3.12 :)
If we agree about above comments, I will post v7 ASAP.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2013-07-26 8:34 UTC|newest]
Thread overview: 320+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 7:07 [PATCH 0/5] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-06-06 7:07 ` [PATCH 1/5] cpufreq: Define cpufreq_set_drv_attr_files() to add per CPU sysfs attributes Lukasz Majewski
2013-06-06 8:27 ` Viresh Kumar
2013-06-06 8:58 ` Lukasz Majewski
2013-06-06 9:00 ` Viresh Kumar
2013-06-06 9:16 ` Lukasz Majewski
2013-06-06 7:07 ` [PATCH 2/5] cpufreq:boost: Add support for software based CPU frequency boost Lukasz Majewski
2013-06-06 10:53 ` Viresh Kumar
2013-06-06 11:49 ` Lukasz Majewski
2013-06-06 15:46 ` Viresh Kumar
2013-06-07 13:27 ` Lukasz Majewski
2013-06-07 14:13 ` Viresh Kumar
2013-06-07 14:34 ` Lukasz Majewski
2013-06-07 14:44 ` Viresh Kumar
2013-06-07 14:43 ` Lukasz Majewski
2013-06-06 7:07 ` [PATCH 3/5] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-06-06 7:07 ` [PATCH 4/5] cpufreq:exynos:Extend exynos cpufreq driver to support boost Lukasz Majewski
2013-06-06 7:07 ` [PATCH 5/5] cpufreq:boost:Kconfig: Enable boost support at Kconfig Lukasz Majewski
2013-06-06 14:49 ` Dave Jones
2013-06-06 15:14 ` Lukasz Majewski
2013-06-06 15:21 ` Dave Jones
2013-06-06 15:48 ` Viresh Kumar
2013-06-06 15:58 ` Borislav Petkov
2013-06-10 13:20 ` Lukasz Majewski
2013-06-10 13:22 ` Viresh Kumar
2013-06-10 13:42 ` Lukasz Majewski
2013-06-11 9:03 ` [PATCH v2 0/3] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-06-11 9:03 ` [PATCH v2 1/3] cpufreq:boost: CPU frequency boost code unification for software and hardware solutions Lukasz Majewski
2013-06-12 5:09 ` Viresh Kumar
2013-06-12 7:39 ` Lukasz Majewski
2013-06-12 8:09 ` Viresh Kumar
2013-06-12 9:09 ` Lukasz Majewski
2013-06-12 9:25 ` Viresh Kumar
2013-06-12 12:30 ` Lukasz Majewski
2013-06-12 11:23 ` Rafael J. Wysocki
2013-06-12 11:40 ` Lukasz Majewski
2013-06-11 9:03 ` [PATCH v2 2/3] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-06-11 9:03 ` [PATCH v2 3/3] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-06-26 11:05 ` Viresh Kumar
2013-06-26 13:58 ` Lukasz Majewski
2013-06-27 4:02 ` Viresh Kumar
2013-06-27 6:31 ` Lukasz Majewski
2013-06-12 5:15 ` [PATCH v2 0/3] cpufreq:boost: CPU Boost mode support Viresh Kumar
2013-06-12 6:00 ` Lukasz Majewski
2013-06-12 6:05 ` Viresh Kumar
2013-06-14 7:38 ` [PATCH v3 " Lukasz Majewski
2013-06-14 7:38 ` [PATCH v3 1/3] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-06-17 5:43 ` Viresh Kumar
2013-06-17 7:15 ` Lukasz Majewski
2013-06-17 7:43 ` Viresh Kumar
2013-06-17 9:08 ` Lukasz Majewski
2013-06-17 9:18 ` Viresh Kumar
2013-06-17 9:58 ` Lukasz Majewski
2013-06-17 13:10 ` Viresh Kumar
2013-06-17 13:51 ` Lukasz Majewski
2013-06-18 6:42 ` Viresh Kumar
2013-06-18 8:24 ` Lukasz Majewski
2013-06-18 8:40 ` Viresh Kumar
2013-06-18 9:12 ` Lukasz Majewski
2013-06-18 13:26 ` Rafael J. Wysocki
2013-06-18 13:44 ` Lukasz Majewski
2013-06-19 7:16 ` Lukasz Majewski
2013-06-20 5:11 ` Viresh Kumar
2013-06-20 6:41 ` Lukasz Majewski
2013-06-20 5:05 ` Viresh Kumar
2013-06-20 5:01 ` Viresh Kumar
2013-06-20 10:04 ` Lukasz Majewski
2013-06-14 7:38 ` [PATCH v3 2/3] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-06-14 7:39 ` [PATCH v3 3/3] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-06-17 3:20 ` [PATCH v3 0/3] cpufreq:boost: CPU Boost mode support Viresh Kumar
2013-06-17 5:41 ` Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 0/7] " Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 1/7] cpufreq: Store cpufreq policies in a list Lukasz Majewski
2013-06-26 10:35 ` Viresh Kumar
2013-06-26 10:54 ` Lukasz Majewski
2013-06-26 10:56 ` Viresh Kumar
2013-06-26 11:04 ` Lukasz Majewski
2013-06-26 11:08 ` Viresh Kumar
2013-06-26 12:15 ` Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 2/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-06-19 17:48 ` Dirk Brandewie
2013-06-19 20:31 ` Lukasz Majewski
2013-06-19 22:25 ` Rafael J. Wysocki
2013-07-17 7:58 ` Viresh Kumar
2013-07-17 11:31 ` Rafael J. Wysocki
2013-07-17 13:01 ` Viresh Kumar
2013-07-17 14:59 ` Lukasz Majewski
2013-07-18 7:51 ` Viresh Kumar
2013-06-20 5:13 ` Viresh Kumar
2013-06-20 20:03 ` Rafael J. Wysocki
2013-06-21 6:23 ` Lukasz Majewski
2013-06-26 10:54 ` Viresh Kumar
2013-06-26 12:54 ` Lukasz Majewski
2013-06-26 14:02 ` Lukasz Majewski
2013-06-27 9:02 ` Viresh Kumar
2013-06-27 9:48 ` Lukasz Majewski
2013-06-27 10:25 ` Viresh Kumar
2013-06-27 11:07 ` Lukasz Majewski
2013-06-27 15:55 ` Lukasz Majewski
2013-06-28 3:40 ` Viresh Kumar
2013-06-28 6:49 ` Lukasz Majewski
2013-06-28 6:51 ` Viresh Kumar
2013-06-28 7:31 ` Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 3/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-06-26 11:03 ` Viresh Kumar
2013-06-26 12:17 ` Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-06-27 8:58 ` Viresh Kumar
2013-06-27 9:08 ` Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 5/7] cpufreq: Calculate number of busy CPUs Lukasz Majewski
2013-06-19 18:01 ` Dirk Brandewie
2013-06-19 20:58 ` Lukasz Majewski
2013-06-19 22:26 ` Rafael J. Wysocki
2013-06-27 9:36 ` Viresh Kumar
2013-06-27 10:58 ` Lukasz Majewski
2013-06-27 11:16 ` Viresh Kumar
2013-06-27 14:42 ` Lukasz Majewski
2013-06-28 3:50 ` Viresh Kumar
2013-06-28 6:54 ` Lukasz Majewski
2013-07-01 8:15 ` Lukasz Majewski
2013-07-04 5:06 ` Viresh Kumar
2013-07-04 5:43 ` Lukasz Majewski
2013-07-04 6:28 ` Viresh Kumar
2013-07-04 6:49 ` Lukasz Majewski
2013-07-04 12:50 ` Rafael J. Wysocki
2013-06-19 17:12 ` [PATCH v4 6/7] cpufreq: Enable software boost only when up to one busy core is running Lukasz Majewski
2013-06-19 17:12 ` [PATCH v4 7/7] thermal:boost: Disable boost when trip point is reached Lukasz Majewski
2013-06-26 7:48 ` [PATCH v4 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-06-26 7:52 ` Viresh Kumar
2013-07-04 8:50 ` [PATCH v5 " Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 1/7] cpufreq: Store cpufreq policies in a list Lukasz Majewski
2013-07-16 8:51 ` Viresh Kumar
2013-07-16 9:39 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 2/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-07-16 9:41 ` Viresh Kumar
2013-07-16 12:06 ` Lukasz Majewski
2013-07-17 5:28 ` Viresh Kumar
2013-07-17 7:00 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 3/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-07-16 10:04 ` Viresh Kumar
2013-07-16 11:17 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-07-16 9:48 ` Viresh Kumar
2013-07-16 10:58 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 5/7] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-07-04 17:19 ` R, Durgadoss
2013-07-04 20:58 ` Lukasz Majewski
2013-07-05 5:31 ` R, Durgadoss
2013-07-05 6:43 ` Lukasz Majewski
2013-07-11 8:08 ` Lukasz Majewski
2013-07-16 7:28 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 6/7] cpufreq:boost:Kconfig: Enable software managed BOOST support at Kconfig Lukasz Majewski
2013-07-16 9:58 ` Viresh Kumar
2013-07-16 11:50 ` Lukasz Majewski
2013-07-17 5:24 ` Viresh Kumar
2013-07-17 7:17 ` Lukasz Majewski
2013-07-17 7:52 ` Viresh Kumar
2013-07-17 8:12 ` Lukasz Majewski
2013-07-17 8:29 ` Viresh Kumar
2013-07-17 9:11 ` Lukasz Majewski
2013-07-04 8:50 ` [PATCH v5 7/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-07-16 10:01 ` Viresh Kumar
2013-07-16 11:33 ` Lukasz Majewski
2013-07-17 5:22 ` Viresh Kumar
2013-07-17 7:36 ` Lukasz Majewski
2013-07-17 7:59 ` Viresh Kumar
2013-07-17 8:13 ` Lukasz Majewski
2013-07-09 7:02 ` [PATCH v5 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-07-09 7:04 ` Viresh Kumar
2013-07-16 7:26 ` Lukasz Majewski
2013-07-16 8:46 ` Viresh Kumar
2013-07-25 16:33 ` [PATCH v6 0/8] " Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 1/8] cpufreq: Store cpufreq policies in a list Lukasz Majewski
2013-07-26 10:14 ` Viresh Kumar
2013-07-26 10:58 ` Lukasz Majewski
2013-07-26 11:02 ` Viresh Kumar
2013-07-26 12:46 ` Lukasz Majewski
2013-07-29 7:03 ` Viresh Kumar
2013-07-25 16:33 ` [PATCH v6 2/8] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-07-26 7:17 ` Viresh Kumar
2013-07-26 8:33 ` Lukasz Majewski [this message]
2013-07-26 9:33 ` Viresh Kumar
2013-07-26 10:10 ` Lukasz Majewski
2013-07-26 9:36 ` Viresh Kumar
2013-07-26 10:11 ` Lukasz Majewski
2013-08-12 9:07 ` Lukasz Majewski
2013-08-12 9:10 ` Viresh Kumar
2013-07-26 12:36 ` Rafael J. Wysocki
2013-07-26 13:08 ` Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 3/8] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-07-26 7:28 ` Viresh Kumar
2013-07-26 8:09 ` Lukasz Majewski
2013-07-26 9:24 ` Viresh Kumar
2013-07-26 9:44 ` Lukasz Majewski
2013-08-12 9:12 ` Lukasz Majewski
2013-08-12 9:14 ` Viresh Kumar
2013-07-25 16:33 ` [PATCH v6 4/8] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-08-12 9:17 ` Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 5/8] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-07-26 10:24 ` Viresh Kumar
2013-07-26 11:21 ` Lukasz Majewski
2013-07-29 6:58 ` Viresh Kumar
2013-08-12 10:26 ` Lukasz Majewski
2013-08-12 10:28 ` Viresh Kumar
2013-08-12 10:50 ` Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 6/8] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-07-26 10:26 ` Viresh Kumar
2013-07-26 11:26 ` Lukasz Majewski
2013-07-29 7:01 ` Viresh Kumar
2013-08-12 9:52 ` Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 7/8] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-07-25 16:33 ` [PATCH v6 8/8] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-07-26 10:28 ` [PATCH v6 0/8] cpufreq:boost: CPU Boost mode support Viresh Kumar
2013-08-13 10:08 ` [PATCH v7 0/7] " Lukasz Majewski
2013-08-13 10:08 ` [PATCH v7 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-08-26 5:28 ` Viresh Kumar
2013-08-26 7:02 ` Lukasz Majewski
2013-08-26 7:06 ` Viresh Kumar
2013-08-26 7:11 ` Lukasz Majewski
2013-08-26 13:12 ` Rafael J. Wysocki
2013-08-26 14:00 ` Viresh Kumar
2013-08-26 14:46 ` Lukasz Majewski
2013-08-13 10:08 ` [PATCH v7 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-08-26 5:32 ` Viresh Kumar
2013-08-13 10:08 ` [PATCH v7 3/7] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-08-26 5:33 ` Viresh Kumar
2013-08-26 6:50 ` Lukasz Majewski
2013-08-13 10:08 ` [PATCH v7 4/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-08-26 5:35 ` Viresh Kumar
2013-08-13 10:08 ` [PATCH v7 5/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-08-26 5:36 ` Viresh Kumar
2013-08-13 10:08 ` [PATCH v7 6/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-08-26 5:36 ` Viresh Kumar
2013-08-13 10:08 ` [PATCH v7 7/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-08-26 5:37 ` Viresh Kumar
2013-08-19 6:38 ` [PATCH v7 0/7] cpufreq:boost: CPU Boost mode support Viresh Kumar
2013-08-19 6:50 ` Lukasz Majewski
2013-08-19 23:29 ` Rafael J. Wysocki
2013-08-20 8:11 ` Lukasz Majewski
2013-08-20 12:32 ` Rafael J. Wysocki
2013-08-26 15:50 ` [PATCH v8 " Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 3/7] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 4/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 5/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 6/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-08-26 15:50 ` [PATCH v8 7/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-09-20 16:00 ` [PATCH RESEND v8 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-09-20 16:00 ` [PATCH RESEND v8 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-09-20 16:00 ` [PATCH RESEND v8 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-09-20 16:01 ` [PATCH RESEND v8 3/7] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-09-20 16:01 ` [PATCH RESEND v8 4/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-09-20 16:01 ` [PATCH RESEND v8 5/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-09-20 16:01 ` [PATCH RESEND v8 6/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-09-20 16:01 ` [PATCH RESEND v8 7/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 3/7] thermal:boost: Automatic enable/disable of BOOST feature Lukasz Majewski
2013-10-15 9:32 ` Zhang Rui
2013-10-15 15:43 ` Lukasz Majewski
2013-10-17 15:09 ` Zhang, Rui
2013-10-14 12:17 ` [PATCH v9 4/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 5/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 6/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-10-14 12:17 ` [PATCH v9 7/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 3/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 5/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 6/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-11-05 17:26 ` [PATCH v10 7/7] thermal:exynos:boost: Automatic enable/disable of BOOST feature (at Exynos4412) Lukasz Majewski
2013-11-28 13:05 ` Lukasz Majewski
2013-12-02 14:53 ` Eduardo Valentin
2013-12-03 7:31 ` Lukasz Majewski
2013-12-03 12:36 ` Eduardo Valentin
2013-12-03 15:42 ` Lukasz Majewski
2013-12-04 14:10 ` Eduardo Valentin
2013-12-05 11:03 ` Lukasz Majewski
2013-12-05 13:25 ` Eduardo Valentin
2013-12-06 14:03 ` Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 3/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 5/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 6/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-12-02 12:19 ` [PATCH RESEND v10 7/7] thermal:exynos:boost: Automatic enable/disable of BOOST feature (at Exynos4412) Lukasz Majewski
2013-12-04 6:59 ` [PATCH RESEND v10 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-12-04 14:12 ` Eduardo Valentin
2013-12-09 10:04 ` Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 " Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 3/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 5/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 6/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-12-13 16:38 ` [PATCH v11 7/7] thermal:exynos:boost: Automatic enable/disable of BOOST feature (at Exynos4412) Lukasz Majewski
2013-12-19 14:50 ` Eduardo Valentin
2013-12-20 14:24 ` [PATCH v12 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 1/7] cpufreq: Add boost frequency support in core Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 2/7] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 3/7] cpufreq:boost:Kconfig: Provide support for software managed BOOST Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 4/7] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 5/7] Documentation:cpufreq:boost: Update BOOST documentation Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 6/7] cpufreq:exynos4x12: Change L0 driver data to CPUFREQ_BOOST_FREQ Lukasz Majewski
2013-12-20 14:24 ` [PATCH v12 7/7] thermal:exynos:boost: Automatic enable/disable of BOOST feature (at Exynos4412) Lukasz Majewski
2014-01-10 6:35 ` Zhang Rui
2014-01-07 6:58 ` [PATCH v12 0/7] cpufreq:boost: CPU Boost mode support Lukasz Majewski
2014-01-08 0:35 ` Rafael J. Wysocki
2014-01-09 7:19 ` Lukasz Majewski
2014-01-10 6:33 ` Zhang Rui
2014-01-16 9:40 ` Lukasz Majewski
2014-01-16 15:51 ` Rafael J. Wysocki
2014-01-16 15:56 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726103321.21238bbb@amdc308.digital.local \
--to=l.majewski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cpufreq@vger.kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=durgadoss.r@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=l.majewski@majess.pl \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).