From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
eranian@google.com, jolsa@redhat.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/5] tools, perf: Add support to evsel for enabling counters
Date: Mon, 5 Aug 2013 13:10:52 -0300 [thread overview]
Message-ID: <20130805161052.GB3228@ghostprotocols.net> (raw)
In-Reply-To: <87eha81qzl.fsf@sejong.aot.lge.com>
Em Mon, Aug 05, 2013 at 05:28:14PM +0900, Namhyung Kim escreveu:
> Hi Andi,
>
> On Fri, 2 Aug 2013 17:41:10 -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Add support for enabling already set up counters by using an
> > ioctl. I share some code with the filter setup.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > ---
> > tools/perf/util/evsel.c | 21 ++++++++++++++++++---
> > tools/perf/util/evsel.h | 1 +
> > 2 files changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index c9c7494..60e0d84 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -605,16 +605,16 @@ int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads)
> > return evsel->fd != NULL ? 0 : -ENOMEM;
> > }
> >
> > -int perf_evsel__set_filter(struct perf_evsel *evsel, int ncpus, int nthreads,
> > - const char *filter)
> > +static int perf_evsel__run_ioctl(struct perf_evsel *evsel, int ncpus, int nthreads,
> > + int ioc, void *arg)
> > {
> > int cpu, thread;
> >
> > for (cpu = 0; cpu < ncpus; cpu++) {
> > for (thread = 0; thread < nthreads; thread++) {
> > int fd = FD(evsel, cpu, thread),
> > - err = ioctl(fd, PERF_EVENT_IOC_SET_FILTER, filter);
> >
> > + err = ioctl(fd, ioc, arg);
>
> Looks very strange to have a blank line between variable declarations.
> You'd better separating declarations on the other lines like:
>
> int fd, err;
>
> fd = FD(evsel, cpu, thread);
> err = ioctl(fd, ioc, arg);
Preferences :-) I think the best way is:
int fd = FD(evsel, cpu, thread),
err = ioctl(fd, ioc, arg);
As its all short and so uses 2 instead of 4 lines. I'll fix up the
alignment.
>
> Thanks,
> Namhyung
>
>
> > if (err)
> > return err;
> > }
next prev parent reply other threads:[~2013-08-05 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 0:41 Misc perf stat improvements Andi Kleen
2013-08-03 0:41 ` [PATCH 1/5] perf, tools: Remove obsolete dummy execve Andi Kleen
2013-08-12 10:19 ` [tip:perf/core] perf evlist: " tip-bot for Andi Kleen
2013-08-03 0:41 ` [PATCH 2/5] tools, perf: Add support to evsel for enabling counters Andi Kleen
2013-08-05 8:28 ` Namhyung Kim
2013-08-05 16:10 ` Arnaldo Carvalho de Melo [this message]
2013-08-12 10:19 ` [tip:perf/core] perf evsel: Add support " tip-bot for Andi Kleen
2013-08-03 0:41 ` [PATCH 3/5] perf, tools: Add support for --initial-delay option to perf stat Andi Kleen
2013-08-12 10:20 ` [tip:perf/core] perf stat: Add support for --initial-delay option tip-bot for Andi Kleen
2013-08-03 0:41 ` [PATCH 4/5] perf, tools: flush output after each line in stat interval mode Andi Kleen
2013-08-12 10:20 ` [tip:perf/core] perf stat: Flush output after each line in " tip-bot for Andi Kleen
2013-08-03 0:41 ` [PATCH 5/5] perf, tools: Output running time and run/enabled ratio in CSV mode Andi Kleen
2013-08-05 9:45 ` Jiri Olsa
2013-08-05 9:45 ` Misc perf stat improvements Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805161052.GB3228@ghostprotocols.net \
--to=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).