From: Sebastian Reichel <sre@debian.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linus.walleij@linaro.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
Carlos Chinea <cch.devel@gmail.com>
Subject: Re: [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information
Date: Fri, 23 Aug 2013 20:29:28 +0200 [thread overview]
Message-ID: <20130823182928.GD5753@earth.universe> (raw)
In-Reply-To: <alpine.DEB.2.02.1308210113040.6426@utopia.booyaka.com>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
Hi Paul,
On Wed, Aug 21, 2013 at 01:22:09AM +0000, Paul Walmsley wrote:
> > From: Sebastian Reichel <sre@ring0.de>
> > This patch adds Synchronous Serial Interface (SSI) hwmod support for
> > OMAP34xx SoCs.
>
> a few comments:
>
> - please add your Signed-off-by: to the patch description, per
> Documentation/SubmittingPatches
I assumed this was only important, when I actually want to submit
patches. This was merely a first RFC. I will do this for the next
round of patches.
> - please drop "omap34xx_ssi_irqs" and "omap34xx_ssi_addrs" - that data
> should go into DT now
I'm currently working on converting the driver to use DT.
I will send another patch when I'm done.
> [...]
> FYI, this is stretching my recollection, and is not directly related to
> this patch, but I seem to recall that there was a problem with auto-idle
> when SSI was active on the 3430. Basically, if the SSI was active, but
> other CORE_L3/CORE_L4 clockdomain devices weren't, I think that DPLL3
> would be incorrectly shut down. You'll probably need to check the Nokia
> kernel source for details. I thought we had a hwmod flag for this, but I
> guess not. Anyway, in case you notice odd behavior...
OK. Thanks for the hint.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-23 18:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 16:13 [RFC PATCH 0/3] OMAP SSI driver Sebastian Reichel
2013-08-11 16:17 ` [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information Sebastian Reichel
2013-08-11 16:17 ` [PATCH 2/3] ARM: OMAP2+: HSI: Introduce OMAP SSI driver Sebastian Reichel
2013-08-12 8:28 ` Tony Lindgren
2013-08-23 13:57 ` Linus Walleij
2013-08-23 18:17 ` Sebastian Reichel
2013-08-11 16:17 ` [PATCH 3/3] ARM: OMAP2+: Add SSI driver configuration Sebastian Reichel
2013-08-12 8:30 ` Tony Lindgren
2013-08-23 13:58 ` Linus Walleij
2013-08-23 18:20 ` Sebastian Reichel
2013-08-26 8:52 ` Tony Lindgren
2013-08-12 8:26 ` [PATCH 1/3] ARM: OMAP2+: hwmod-data: Add SSI information Tony Lindgren
2013-08-21 1:22 ` Paul Walmsley
2013-08-23 18:29 ` Sebastian Reichel [this message]
2013-08-23 18:53 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823182928.GD5753@earth.universe \
--to=sre@debian.org \
--cc=cch.devel@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=omaplinuxkernel@gmail.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).