From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517Ab3IKEvM (ORCPT ); Wed, 11 Sep 2013 00:51:12 -0400 Received: from one.firstfloor.org ([193.170.194.197]:48237 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208Ab3IKEvL (ORCPT ); Wed, 11 Sep 2013 00:51:11 -0400 Date: Wed, 11 Sep 2013 06:51:09 +0200 From: Andi Kleen To: Andrew Morton Cc: Geert Uytterhoeven , Andi Kleen , "linux-kernel@vger.kernel.org" , the arch/x86 maintainers , Peter Zijlstra , Andi Kleen Subject: Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users Message-ID: <20130911045109.GE18242@two.firstfloor.org> References: <1376687844-19857-1-git-send-email-andi@firstfloor.org> <1376687844-19857-4-git-send-email-andi@firstfloor.org> <20130910165212.b95be29e2816dc69c909c058@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130910165212.b95be29e2816dc69c909c058@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote: > On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven wrote: > > > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > > > need to include linux/sched.h > > > > Really? is the worst choice w.r.t. include hell. > > Yes. Mechanically adding sched.h inclusions into .h files will cause > problems. > > I've had decent success with this sort of thing by adding new, > finer-grained headers. Maybe include/linux/might_sleep.h would be a > good starting point to fix whatever it was that this fixed. Ok. I'll look into that and send new patches. Some of it may be obsolete with Peter's recent preempt work. > I think I'll make x86-include-linux-schedh-in-asm-uaccessh.patch, > tree-sweep-include-linux-schedh-for-might_sleep-users.patch and > sched-mark-should_resched-__always_inline.patch go away for now - I > need a mergeable tree, fast. Fair enough. -Andi -- ak@linux.intel.com -- Speaking for myself only.