Re: [GIT PULL] perf fixes

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Thu, Sep 12, 2013 at 10:18:55PM +0200, Ingo Molnar escreveu:
> * David Ahern <dsahern@gmail.com> wrote:
> 
> > On 9/12/13 11:43 AM, Arnaldo Carvalho de Melo wrote:
> 
> > > Its something that annoys me as well, but not so much as to make me 
> > > figure out how to make those be done only if some source file changed.
> > 
> > Jiri and I have both taken stabs at a config-based build rather than 
> > probing. Just need to finish it.
> 
> Mind outlining the approach you are thinking about?
> 
> Firstly, please don't even think about autotools. (Just forget it exists.)

hehe, no, that wasn't considered.
 
> Secondly, the way perf tries to build by auto-detecting the build 
> environment and auto-disabling bits it cannot build just yet is pretty 
> powerful. The core bits will build on just about any system, and our 
> fallbacks are really good.

That would remain as:

make -C tools/perf autoconfig
 
> The result is that perf will build on just about any random system, 
> without the user having to install any dependency. It would be really sad 
> to lose that aspect.

we will not

> What I think would work best is what I outlined in the previous mail: to 
> cache successful feature test results and only re-do unsuccessful tests: 
> those are the ones that are expected to turn into successful tests in the 
> future, once the missing dependencies are installed.

that is an optimization to 'make autoconfig', i.e. what we have now,
improved.
 
> Since most tests succeed even on a sparsely installed system, this trick 
> alone will speed up the checks big time.
> 
> Furthermore, this method would encourage people to install the 
> dependencies - and perf developers, who do many repeat builds after 
> trivial one-file changes, will typically have all dependencies installed 
> anyway, so for them such a caching feature would result in totally cached 
> feature tests and very fast build times.

What he mentioned is the multiple attempts at doing:

make -C tools/perf menuconfig

and use kbuild to allow one to select what he/she wants to build, i.e.
using the kernel config system in perf.

In that case the feature checks would be triggered only for the features
selected, not for all perf currently selectable features.

- Arnaldo