From: Ingo Molnar <mingo@kernel.org>
To: Petr Holasek <pholasek@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Jiri Olsa <jolsa@redhat.com>, Petr Benas <pbenas@redhat.com>
Subject: Re: [PATCH] perf: Fix failing assertions in perf bench numa
Date: Fri, 4 Oct 2013 08:02:27 +0200 [thread overview]
Message-ID: <20131004060227.GC11399@gmail.com> (raw)
In-Reply-To: <1380821325-4017-1-git-send-email-pholasek@redhat.com>
* Petr Holasek <pholasek@redhat.com> wrote:
> Patch adds more subtle handling of -C and -N parameters in
> parse_{cpu,node}_setup_list() functions when there isn't enough NUMA nodes or
> CPUs present.
> Instead of assertion and terminating benchmark, partial test is skipped
> with error message and perf will continue to the next one.
>
> Fixed problem can be easily reproduced on machine with only one NUMA node:
>
> # Running numa/mem benchmark...
>
> # Running main, "perf bench numa mem -a"
>
> ...
>
> # Running RAM-bw-remote, "perf bench numa mem -p 1 -t 1 -P 1024 -C 0 -M 1 -s
> perf: bench/numa.c:622: parse_setup_node_list: Assertion `!(bind_node_0 < 0 ||
> bind_node_0 >= g->p.nr_nodes)' failed.
> Aborted
>
> Signed-off-by: Petr Benas <pbenas@redhat.com>
> Signed-off-by: Petr Holasek <pholasek@redhat.com>
Thanks Petr!
Acked-by: Ingo Molnar <mingo@kernel.org>
Ingo
next prev parent reply other threads:[~2013-10-04 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 17:28 [PATCH] perf: Fix failing assertions in perf bench numa Petr Holasek
2013-10-04 6:02 ` Ingo Molnar [this message]
2013-10-15 5:29 ` [tip:perf/core] perf bench: Fix failing assertions in numa bench tip-bot for Petr Holasek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004060227.GC11399@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbenas@redhat.com \
--cc=pholasek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).