linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: [PATCHv2] checkpatch.pl: Check for the FSF mailing address
Date: Sun, 6 Oct 2013 15:23:42 -0700	[thread overview]
Message-ID: <20131006222342.GT19510@leaf> (raw)
In-Reply-To: <1381096127.2081.166.camel@joe-AO722>

Kernel maintainers reject new instances of the GPL boilerplate paragraph
directing people to write to the FSF for a copy of the GPL, since the
FSF has moved in the past and may do so again.

Make this an error for new code, but just a --strict CHK in --file mode;
anyone interested in doing tree-wide cleanups of this form can enable
this test explicitly.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---

v2: Make this a CHK in --file mode, using a code pattern suggested by
    Joe Perches.

 scripts/checkpatch.pl | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2ee9eb7..9161533 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1859,6 +1859,18 @@ sub process {
 			$rpt_cleaners = 1;
 		}
 
+# Check for FSF mailing addresses.
+		if ($rawline =~ /You should have received a copy/ ||
+		    $rawline =~ /write to the Free Software/ ||
+		    $rawline =~ /59 Temple Place/ ||
+		    $rawline =~ /51 Franklin Street/) {
+			my $herevet = "$here\n" . cat_vet($rawline) . "\n";
+			my $msg_type = \&ERROR;
+			$msg_type = \&CHK if ($file);
+			&{$msg_type}("FSF_MAILING_ADDRESS",
+				"Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
+		}
+
 # check for Kconfig help text having a real description
 # Only applies when adding the entry originally, after that we do not have
 # sufficient context to determine whether it is indeed long enough.
-- 
1.8.4.rc3


  reply	other threads:[~2013-10-06 22:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-05 18:43 [PATCH] " Josh Triplett
2013-10-05 18:51 ` Joe Perches
2013-10-05 19:03   ` Josh Triplett
2013-10-06  6:27   ` Greg Kroah-Hartman
2013-10-06  7:01     ` Joe Perches
2013-10-06  7:05       ` Greg Kroah-Hartman
2013-10-06  8:10         ` Borislav Petkov
2013-10-06 13:44           ` Greg Kroah-Hartman
2013-10-06 13:55             ` Borislav Petkov
2013-10-06 19:18               ` Greg Kroah-Hartman
2013-10-06 20:07                 ` Borislav Petkov
2013-10-06 19:19       ` Rob Landley
2013-10-06 21:16       ` Josh Triplett
2013-10-06 21:18     ` Josh Triplett
2013-10-06 21:27       ` Joe Perches
2013-10-06 21:33         ` Josh Triplett
2013-10-06 21:48           ` Joe Perches
2013-10-06 22:23             ` Josh Triplett [this message]
2013-10-06 23:05               ` [PATCHv2] " Greg Kroah-Hartman
2013-10-06 23:16               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131006222342.GT19510@leaf \
    --to=josh@joshtriplett.org \
    --cc=apw@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCHv2] checkpatch.pl: Check for the FSF mailing address' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).