From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754947Ab3JHIg4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Oct 2013 04:36:56 -0400
Received: from mail-ea0-f174.google.com ([209.85.215.174]:43138 "EHLO
	mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752143Ab3JHIgw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Oct 2013 04:36:52 -0400
Date: Tue, 8 Oct 2013 10:36:48 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 36/50] tools/perf/build: Speed up auto-detection
Message-ID: <20131008083648.GA3295@gmail.com>
References: <1381147003-2574-1-git-send-email-mingo@kernel.org>
 <1381147003-2574-37-git-send-email-mingo@kernel.org>
 <20131007215704.GD2900@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131007215704.GD2900@krava.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Mon, Oct 07, 2013 at 01:56:29PM +0200, Ingo Molnar wrote:
> 
> SNIP
> 
> > -FEATURE_TESTS =				\
> > -	hello				\
> > -	stackprotector-all		\
> > -	stackprotector			\
> > -	volatile-register-var		\
> > +#
> > +# Note that this is not a complete list of all feature tests, just
> > +# those that are typically built on a fully configured system.
> > +#
> > +# [ Feature tests not mentioned here have to be built explicitly in
> > +#   the rule that uses them - an example for that is the 'bionic'
> > +#   feature check. ]
> > +#
> > +CORE_FEATURE_TESTS =			\
> > +	backtrace			\
> > +	dwarf				\
> >  	fortify-source			\
> > -	bionic				\
> > -	libelf				\
> >  	glibc				\
> > -	dwarf				\
> > -	libelf-mmap			\
> > -	libelf-getphdrnum		\
> > -	libunwind			\
> > -	libaudit			\
> > -	libslang			\
> >  	gtk2				\
> >  	gtk2-infobar			\
> > +	libaudit			\
> > +	libbfd				\
> > +	libelf				\
> > +	libelf-getphdrnum		\
> > +	libelf-mmap			\
> > +	libnuma				\
> >  	libperl				\
> >  	libpython			\
> >  	libpython-version		\
> > -	libbfd				\
> > +	libslang			\
> > +	libunwind			\
> >  	on-exit				\
> > -	backtrace			\
> > -	libnuma
> > +	stackprotector-all		\
> 
> missing stackprotector?

Thanks, fixed.

Btw., this was amazing of you to find during review, from such a 
supposedly identity transformation patch! :)

> I guess that various gcc version could support either
> of them or both.. so we need to check for both
> 
> looks like -fstack-protector-all overloads -fstack-protector
> but no harm to have them both added probably ;-)

Yeah, both checks were there originally and it was an oversight from me 
to have only stackprotector-all in the final result.

(Had I left it out intentionally it would have been either a separate 
patch, or at least would have earned a mention in the changelog.)

Thanks,

	Ingo