From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757381Ab3JIMGG (ORCPT ); Wed, 9 Oct 2013 08:06:06 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38198 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444Ab3JIMGE (ORCPT ); Wed, 9 Oct 2013 08:06:04 -0400 Date: Wed, 9 Oct 2013 14:05:44 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Mel Gorman , Rik van Riel , Srikar Dronamraju , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML Subject: Re: [PATCH 0/63] Basic scheduler support for automatic NUMA balancing V9 Message-ID: <20131009120544.GE3081@twins.programming.kicks-ass.net> References: <1381141781-10992-1-git-send-email-mgorman@suse.de> <20131009110353.GA19370@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131009110353.GA19370@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 09, 2013 at 01:03:54PM +0200, Ingo Molnar wrote: > kernel/sched/fair.c:819:22: warning: 'task_h_load' declared 'static' but never defined [-Wunused-function] Not too pretty, but it avoids the warning: --- --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -681,6 +681,8 @@ static u64 sched_vslice(struct cfs_rq *c } #ifdef CONFIG_SMP +static unsigned long task_h_load(struct task_struct *p); + static inline void __update_task_entity_contrib(struct sched_entity *se); /* Give new task start runnable values to heavy its load in infant time */ @@ -816,8 +818,6 @@ update_stats_curr_start(struct cfs_rq *c * Scheduling class queueing methods: */ -static unsigned long task_h_load(struct task_struct *p); - #ifdef CONFIG_NUMA_BALANCING /* * Approximate time to scan a full NUMA task in ms. The task scan period is