From: Ingo Molnar <mingo@kernel.org>
To: hpa@zytor.com, linux-kernel@vger.kernel.org,
keescook@chromium.org, md@google.com, tglx@linutronix.de,
hpa@linux.intel.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/kaslr] x86, relocs: Add more per-cpu gold special cases
Date: Mon, 14 Oct 2013 11:38:27 +0200 [thread overview]
Message-ID: <20131014093826.GA22177@gmail.com> (raw)
In-Reply-To: <20131014083035.GA20976@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
> * tip-bot for Michael Davidson <tipbot@zytor.com> wrote:
>
> > Commit-ID: d751c169e9a6f0f853346f1184881422bd10b3c2
> > Gitweb: http://git.kernel.org/tip/d751c169e9a6f0f853346f1184881422bd10b3c2
> > Author: Michael Davidson <md@google.com>
> > AuthorDate: Thu, 10 Oct 2013 18:39:54 -0700
> > Committer: H. Peter Anvin <hpa@linux.intel.com>
> > CommitDate: Sun, 13 Oct 2013 03:11:57 -0700
> >
> > x86, relocs: Add more per-cpu gold special cases
>
> I'm quite sure that one of the recent x86/kaslr changes causes this
> early x86-64 crash:
excluding tip:x86/kaslr fixes the crash. So it's one of these commits:
6e6a4932b0f5 x86, boot: Rename get_flags() and check_flags() to *_cpuflags()
6145cfe394a7 x86, kaslr: Raise the maximum virtual address to -1 GiB on x86_64
f32360ef6608 x86, kaslr: Report kernel offset on panic
82fa9637a2ba x86, kaslr: Select random position from e820 maps
5bfce5ef55cb x86, kaslr: Provide randomness functions
8ab3820fd5b2 x86, kaslr: Return location from decompress_kernel
dd78b97367bd x86, boot: Move CPU flags out of cpucheck
d751c169e9a6 x86, relocs: Add more per-cpu gold special cases
One guess would be:
dd78b97367bd x86, boot: Move CPU flags out of cpucheck
That commit is crazy large - it should be done in at least two steps:
- first the movement to cpuflags.c
- the PIC-safe refactoring
Also, checking:
82fa9637a2ba x86, kaslr: Select random position from e820 maps
I see:
+#ifdef CONFIG_X86_64
+#define memptr long
+#else
+#define memptr unsigned
+#endif
wtf? That should really be cleaned up while we are touching that code.
Thanks,
Ingo
next prev parent reply other threads:[~2013-10-14 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 1:39 [PATCH v2] x86, relocs: add more per-cpu gold special cases Kees Cook
2013-10-13 12:01 ` [tip:x86/kaslr] x86, relocs: Add " tip-bot for Michael Davidson
2013-10-14 8:30 ` Ingo Molnar
2013-10-14 9:38 ` Ingo Molnar [this message]
2013-10-14 14:19 ` H. Peter Anvin
2013-10-14 16:28 ` H. Peter Anvin
2013-10-14 20:47 ` Kees Cook
2013-10-15 6:04 ` Ingo Molnar
2013-10-15 15:42 ` Kees Cook
2013-10-15 16:03 ` Ingo Molnar
2013-10-15 17:22 ` Kees Cook
2013-10-16 6:56 ` Ingo Molnar
2013-10-16 14:53 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014093826.GA22177@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=md@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).