archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Namhyung Kim <>
Cc: Arnaldo Carvalho de Melo <>,
	Peter Zijlstra <>,
	Paul Mackerras <>,
	Namhyung Kim <>,
	LKML <>, Jiri Olsa <>,
	David Ahern <>
Subject: Re: [PATCH 1/2] perf tools: Compare dso's also when comparing symbols
Date: Tue, 15 Oct 2013 08:08:29 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

* Namhyung Kim <> wrote:

> From: Namhyung Kim <>
> Linus reported that sometimes 'perf report -s symbol' exits without any 
> message on TUI.  David and Jiri found that it's because it failed to add 
> a hist entry due to an invalid symbol length.

Btw., 'exit without any messages' is something that should be fixed 
separately as well I suspect.

>  static int64_t
>  sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
>  {
> +	int64_t ret;
> +

Btw., this file should go back to u64/s64 like the kernel and most of perf 
does. (A few int64_t uses slipped into other places as well, I suspect 
they should be fixed.)



  parent reply	other threads:[~2013-10-15  6:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  2:01 Namhyung Kim
2013-10-15  2:01 ` [RFC/PATCH 2/2] perf tools: Sort dso using pointers Namhyung Kim
2013-10-15  6:08 ` Ingo Molnar [this message]
2013-10-15  7:12   ` [PATCH 1/2] perf tools: Compare dso's also when comparing symbols Namhyung Kim
2013-10-23  7:54 ` [tip:perf/core] perf tools: Compare dso' s " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] perf tools: Compare dso'\''s also when comparing symbols' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).