From: Thierry Reding <thierry.reding@gmail.com>
To: Mark Zhang <nvmarkzhang@gmail.com>
Cc: rpurdie@rpsys.net, jg1.han@samsung.com,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
tomi.valkeinen@ti.com, linux-pwm@vger.kernel.org,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: How to set fops in "struct platform_pwm_backlight_data"?
Date: Wed, 23 Oct 2013 10:00:03 +0200 [thread overview]
Message-ID: <20131023080002.GB7404@ulmo.nvidia.com> (raw)
In-Reply-To: <52673178.8070805@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
On Wed, Oct 23, 2013 at 10:16:24AM +0800, Mark Zhang wrote:
> On 10/22/2013 08:49 PM, Thierry Reding wrote:
> > On Tue, Oct 22, 2013 at 04:55:09PM +0800, Mark Zhang wrote:
> >> On 10/22/2013 03:24 PM, Thierry Reding wrote:
> >>> On Fri, Oct 18, 2013 at 12:48:12PM +0800, Mark Zhang wrote:
> >> [...]
> >>>>>
> >>>>
> >>>> Okay, I just want to set the "notify" function pointer in "struct
> >>>> platform_pwm_backlight_data", because I want to tune the brightness
> >>>> value before the pwm-bl sets the brightness to hardware. I don't know
> >>>> how to do that, unless we define the platform data explicitly.
> >>>
> >>> Okay, my question should have been what you need the functions for and
> >>> why you think you need them.
> >>>
> >>
> >> If I understanding you correctly, I suppose I've said that: "because I
> >> want to tune the brightness value before the pwm-bl sets the brightness
> >> to hardware".
> >
> > Why do you want to tune the brightness value? What are you trying to
> > achieve?
> >
>
> Oh, Tegra has a feature named PRISM(aka SmartDimmer). It changes the
> color value to make the display looks bright so that we can reduce the
> backlight brightness to save power. So everytime PRISM is triggered, we
> call "backlight_update_status", then in the "notify" callback, we change
> the brightness value which pwm-bl provides by considering the PRISM
> compensations.
If you automatically call backlight_update_status() everytime PRISM
gives you new data, can't you just pass the correct value in in the
first place so that you don't have to tweak it in the .notify()
callback?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-23 8:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 6:49 How to set fops in "struct platform_pwm_backlight_data"? Mark Zhang
2013-10-17 7:14 ` Thierry Reding
2013-10-18 4:48 ` Mark Zhang
2013-10-22 2:41 ` Mark Zhang
2013-10-22 7:24 ` Thierry Reding
2013-10-22 8:55 ` Mark Zhang
2013-10-22 12:49 ` Thierry Reding
2013-10-23 2:16 ` Mark Zhang
2013-10-23 8:00 ` Thierry Reding [this message]
2013-10-23 8:49 ` Mark Zhang
2013-10-23 9:09 ` Thierry Reding
2013-10-23 10:31 ` Mark Zhang
2013-10-23 10:54 ` Thierry Reding
2013-10-23 11:33 ` Mark Zhang
2013-10-23 10:36 ` Mark Zhang
2013-10-23 10:46 ` Mark Zhang
2013-10-23 10:58 ` Thierry Reding
2013-10-23 11:34 ` Mark Zhang
2013-10-23 10:51 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023080002.GB7404@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nvmarkzhang@gmail.com \
--cc=plagnioj@jcrosoft.com \
--cc=rpurdie@rpsys.net \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).