From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658Ab3KABVf (ORCPT ); Thu, 31 Oct 2013 21:21:35 -0400 Received: from toccata.ens-lyon.org ([140.77.166.68]:40950 "EHLO toccata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754219Ab3KABVd (ORCPT ); Thu, 31 Oct 2013 21:21:33 -0400 Date: Fri, 1 Nov 2013 02:21:29 +0100 From: Samuel Thibault To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@type.youpi.perso.aquilenet.fr Subject: Re: linux-next: Tree for Oct 31 (input & leds) Message-ID: <20131101012129.GW7325@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@toccata.ens-lyon.org References: <20131031210027.cb3604b9589e0b7a1599dbd2@canb.auug.org.au> <52729BCB.1000700@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52729BCB.1000700@infradead.org> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap, le Thu 31 Oct 2013 11:04:59 -0700, a écrit : > On 10/31/13 03:00, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20131030: > > > > The net-next tree gained a conflict against the net tree. > > > > The devicetree tree gained a conflict against the crypto tree. > > > > The tty tree gained a build failure so I used the version from > > next-20131030. > > > > The arm-soc tree gained conflicts against the devicetree tree. > > > on i386, when both > CONFIG_INPUT=m > CONFIG_INPUT_LEDS=m > > ERROR: "input_led_disconnect" [drivers/input/input-core.ko] undefined! > ERROR: "input_led_connect" [drivers/input/input-core.ko] undefined! > > > Full randconfig file is attached. Ah, right, in that config an export is needed, here is a patch. Samuel Export input led symbols for input core module. Signed-off-by: Samuel Thibault --- drivers/input/leds.c.orig 2013-11-01 01:43:38.889584308 +0100 +++ drivers/input/leds.c 2013-11-01 01:44:02.060916781 +0100 @@ -210,6 +210,7 @@ input_led_delete(dev); return error; } +EXPORT_SYMBOL_GPL(input_led_connect); /* Disconnected input device. Clean it, and deregister now-useless VT LEDs * and triggers. */ @@ -241,6 +242,7 @@ } mutex_unlock(&vt_led_registered_lock); } +EXPORT_SYMBOL_GPL(input_led_disconnect); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("User LED support for input layer");