From: Dan Carpenter <dan.carpenter@oracle.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] fat: double unlock on error path
Date: Thu, 7 Nov 2013 10:41:08 +0300 [thread overview]
Message-ID: <20131107074108.GB21844@elgon.mountain> (raw)
There is a stray unlock here which was not intended. I have removed it.
Fixes: 3f9f3dfb5755 ('fat: add fat_fallocate operation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/fat/file.c b/fs/fat/file.c
index 03f716f..befedee 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -257,10 +257,8 @@ static long fat_fallocate(struct file *file, int mode,
goto error;
err = inode_newsize_ok(inode, (len + offset));
- if (err) {
- mutex_unlock(&inode->i_mutex);
+ if (err)
goto error;
- }
if (mode & FALLOC_FL_KEEP_SIZE) {
/* First compute the number of clusters to be allocated */
next reply other threads:[~2013-11-07 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:41 Dan Carpenter [this message]
2013-11-08 5:06 ` [patch] fat: double unlock on error path OGAWA Hirofumi
2013-11-08 6:20 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107074108.GB21844@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).