From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755162Ab3KLMnc (ORCPT ); Tue, 12 Nov 2013 07:43:32 -0500 Received: from imap.thunk.org ([74.207.234.97]:57027 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657Ab3KLMnZ (ORCPT ); Tue, 12 Nov 2013 07:43:25 -0500 Date: Mon, 11 Nov 2013 19:30:18 -0500 From: "Theodore Ts'o" To: David Turner Cc: Mark Harris , Andreas Dilger , Jan Kara , Ext4 Developers List , Linux Kernel Mailing List Subject: Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values Message-ID: <20131112003018.GA30281@thunk.org> Mail-Followup-To: Theodore Ts'o , David Turner , Mark Harris , Andreas Dilger , Jan Kara , Ext4 Developers List , Linux Kernel Mailing List References: <1383808590.23882.13.camel@chiang> <20131107160341.GA3850@quack.suse.cz> <1383864864.23882.33.camel@chiang> <20131107231445.GG2054@quack.suse.cz> <1383866807.23882.41.camel@chiang> <1383981551.8994.27.camel@chiang> <1384070214.8994.47.camel@chiang> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384070214.8994.47.camel@chiang> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > b. Use Andreas's encoding, which is incompatible with pre-1970 files > written on 64-bit systems. > > I don't care about currently-existing post-2038 files, because I believe > that nobody has a valid reason to have such files. However, I do > believe that pre-1970 files are probably important to someone. > > Despite this, I prefer option (b), because I think the simplicity is > valuable, and because I hate to give up date ranges (even ones that I > think we'll "never" need). Option (b) is not actually lossy, because we > could correct pre-1970 files with e2fsck; under Andreas's encoding, > their dates would be in the far future (and thus cannot be legitimate). > > Would a patch that does (b) be accepted? I would accompany it with a > patch to e2fsck (which I assume would also go to the ext4 developers > mailing list?). I agree, I think this is the best way to go. I'm going to drop your earlier patch, and wait for an updated patch from you. It may miss this merge window, but as Andreas has pointed out, we still have a few years to get this right. :-) Thanks!! - Ted