From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349Ab3KSVL3 (ORCPT ); Tue, 19 Nov 2013 16:11:29 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:44246 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334Ab3KSVLZ (ORCPT ); Tue, 19 Nov 2013 16:11:25 -0500 Date: Tue, 19 Nov 2013 13:11:21 -0800 From: Anton Vorontsov To: Shuah Khan Cc: len.brown@intel.com, pavel@ucw.cz, rjw@rjwysocki.net, gregkh@linuxfoundation.org, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, shuahkhan@gmail.com Subject: Re: [PATCH 0/2] power_supply: Fix Oops from NULL pointer dereference from wakeup_source_activate Message-ID: <20131119211121.GA20193@teo> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2013 at 08:59:34AM -0700, Shuah Khan wrote: > power_supply_register() calls device_init_wakeup() to register a wakeup > source before initializing dev_name. As a result, device_wakeup_enable() > end up registering wakeup source with a null name when wakeup_source_register() > gets called with dev_name(dev) which is null at the time. > > device_wakeup_enable() uses dev_name(dev) as the wakeup source name. > When it gets called with a device with its name not yet set, ws structure > with ws->name = NULL gets created. > > When kernel is booted with wakeup_source_activate enabled, it will panic > when the trace point code tries to dereferences ws->name. > > This patch series fixes power_supply_register() to initialize the device name > prior to calling device_init_wakeup() and adds WARN_ON on null device name to > device_wakeup_enable() to detect driver bugs that result in calling > device_wakeup_enable() before device is fully initialized with its name in > device_wakeup_enable(). > > It is important that these two fixes to be pulled in together as a series. The > change to add WARN_ON on null device name without the power_supply_register() > fix will result in early boot panics when AC Adapter and Battery device drivers > try to register wakeup source. I am all for it, so for the power_supply part: Acked-by: Anton Vorontsov