From: Sebastian Reichel <sre@ring0.de>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
freemangordon@abv.bg, aaro.koskinen@iki.fi, pavel@ucw.cz
Subject: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode
Date: Sun, 24 Nov 2013 20:26:09 +0100 [thread overview]
Message-ID: <20131124192608.GA11338@earth.universe> (raw)
In-Reply-To: <201311242001.16299@pali>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote:
> > I'm wondering if the watchdog thread should check some values,
> > like e.g. battery temperature. It should stop charging the
> > battery if some critical battery temperature threshold is
> > reached.
>
> For checking battery temperature is needed third driver
> (rx51_battery.ko).
I know, but that doesn't mean one can skip the check.
> And I think this should not be implemented in driver itself but in
> charger manager framework...
There is a reason, that the HW has a watchdog. I think the safety
relevant stuff should be done in the watchdog thread. This ensures,
that charging depends on reading the safety relevant sensors.
Of course the watchdog stuff could be moved into the charger manager
framework...
> Currently on Maemo 5 this is handled in userspace (with open
> source dsme daemon).
I assume it currently also takes care of the bq2415x watchdog? That
means if the daemon dies charging will stop, because the watchdog
does no longer trigger.
When your patch is applied you have introduced a safety issue.
When the daemon dies charging will continue and temperature is
no longer checked.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-24 19:26 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 8:50 [PATCH 0/4] Add support for charging battery in Nokia RX-51 Pali Rohár
2013-09-08 8:50 ` [PATCH 1/4] usb: musb: Call atomic_notifier_call_chain when status is changed Pali Rohár
2013-09-17 15:48 ` Felipe Balbi
2013-09-17 15:49 ` Felipe Balbi
2013-09-17 16:05 ` Pali Rohár
2013-09-17 16:08 ` Felipe Balbi
2013-09-17 19:28 ` Pali Rohár
2013-09-18 1:49 ` Felipe Balbi
2013-09-18 8:20 ` Pali Rohár
2013-09-18 9:04 ` Javier Martinez Canillas
2013-09-18 13:30 ` Pavel Machek
2013-09-18 13:57 ` Javier Martinez Canillas
2013-09-18 14:22 ` Pavel Machek
2013-09-18 14:35 ` Pavel Machek
2013-09-18 16:25 ` Felipe Balbi
2013-09-18 14:53 ` Javier Martinez Canillas
2013-09-18 15:56 ` Pali Rohár
2013-09-18 16:36 ` Felipe Balbi
2013-09-18 16:43 ` Pali Rohár
2013-09-18 16:48 ` Felipe Balbi
2013-09-18 17:03 ` [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD Pali Rohár
2013-09-25 8:17 ` Pali Rohár
2013-09-25 20:33 ` Felipe Balbi
2013-09-26 0:00 ` Pavel Machek
2013-10-01 14:22 ` Felipe Balbi
2013-09-18 17:03 ` [PATCH usb 2/2] usb: musb: Call atomic_notifier_call_chain when status is changed Pali Rohár
2013-09-08 8:50 ` [PATCH 2/4] power: isp1704_charger: Fix driver to work with changes introduced in v3.5 Pali Rohár
2013-10-22 21:03 ` Anton Vorontsov
2013-09-08 8:50 ` [PATCH 3/4] power: isp1704_charger: Add callback function set_current Pali Rohár
2013-09-08 8:50 ` [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger Pali Rohár
2013-09-09 13:39 ` Sebastian Reichel
2013-09-20 19:22 ` Pali Rohár
2013-09-23 18:03 ` Tony Lindgren
2013-09-23 19:16 ` Pali Rohár
2013-09-23 20:00 ` Sebastian Reichel
2013-09-23 20:06 ` Pali Rohár
2013-09-23 20:47 ` Sebastian Reichel
2013-09-23 23:11 ` Tony Lindgren
2013-09-24 0:05 ` Pavel Machek
2013-09-24 17:05 ` Pali Rohár
2013-09-24 20:50 ` Sebastian Reichel
2013-09-14 9:38 ` [PATCH 0/4] Add support for charging battery in Nokia RX-51 Pali Rohár
2013-09-21 13:42 ` Pali Rohár
2013-11-19 10:18 ` [PATCH v2 0/3] " Pali Rohár
2013-11-19 10:18 ` [PATCH v2 1/3] power_supply: Add power_supply notifier Pali Rohár
2013-11-19 13:10 ` Pavel Machek
2013-11-19 13:19 ` Pali Rohár
2013-11-24 17:02 ` Sebastian Reichel
2013-11-27 17:23 ` Tc, Jenny
2013-12-01 22:20 ` Anton Vorontsov
2013-12-01 22:23 ` Anton Vorontsov
2014-01-03 11:09 ` Tc, Jenny
2014-01-03 16:02 ` Anton Vorontsov
2013-11-19 10:18 ` [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode Pali Rohár
2013-11-19 13:24 ` Pavel Machek
2013-12-24 1:58 ` Anton Vorontsov
2013-11-24 17:00 ` Sebastian Reichel
2013-11-24 19:01 ` Pali Rohár
2013-11-24 19:26 ` Sebastian Reichel [this message]
2013-11-24 19:41 ` Pali Rohár
2013-11-24 21:00 ` Sebastian Reichel
2013-11-25 14:01 ` Pavel Machek
2013-11-25 14:10 ` Pali Rohár
2013-11-25 15:18 ` Pavel Machek
2013-11-25 18:52 ` Pali Rohár
2013-11-24 17:18 ` Michael Trimarchi
2013-11-24 19:01 ` Pali Rohár
2013-11-25 19:16 ` Michael Trimarchi
2013-12-01 22:37 ` Anton Vorontsov
2013-12-02 0:02 ` Michael Trimarchi
2013-12-02 0:24 ` Anton Vorontsov
2013-12-02 1:45 ` Michael Trimarchi
2014-01-19 20:54 ` Sebastian Reichel
2014-01-19 20:56 ` Michael Trimarchi
2014-01-20 10:21 ` Russell King - ARM Linux
2014-01-20 11:24 ` Sebastian Reichel
2013-12-06 13:32 ` Pali Rohár
2013-11-19 10:18 ` [PATCH v2 3/3] RX-51: Add platform data for bq24150a charger Pali Rohár
2013-11-19 13:32 ` Pavel Machek
2013-11-24 10:28 ` Pali Rohár
2013-11-19 14:44 ` [PATCH v2 0/3] Add support for charging battery in Nokia RX-51 Sebastian Reichel
2013-11-19 15:40 ` Tony Lindgren
2013-11-19 21:38 ` Pali Rohár
2013-11-25 17:01 [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode Ивайло Димитров
2013-11-25 17:14 ` Sebastian Reichel
2013-11-25 18:32 Ивайло Димитров
2013-11-25 21:50 ` Sebastian Reichel
2013-11-27 21:16 ` Pali Rohár
2013-11-28 0:25 ` Sebastian Reichel
2013-11-28 6:53 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131124192608.GA11338@earth.universe \
--to=sre@ring0.de \
--cc=aaro.koskinen@iki.fi \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).