From: Vinod Koul <vinod.koul@intel.com>
To: Olof Johansson <olof@lixom.net>
Cc: Dan Williams <dan.j.williams@intel.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
dmaengine@vger.kernel.org, nicolas.ferre@atmel.com,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] dmaengine: at_hdmac: remove unused function
Date: Thu, 28 Nov 2013 11:31:49 +0530 [thread overview]
Message-ID: <20131128060149.GP8834@intel.com> (raw)
In-Reply-To: <1385491415-31325-1-git-send-email-olof@lixom.net>
On Tue, Nov 26, 2013 at 10:43:35AM -0800, Olof Johansson wrote:
> commit 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> refactored some code which resulted in an unused function in the at_hdmac
> driver:
>
> drivers/dma/at_hdmac_regs.h:350:23: warning: 'chan2parent' defined but
> not used [-Wunused-function]
>
> Fixes: 54f8d501e8428 ('dmaengine: remove DMA unmap from drivers')
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Vinod Koul <vinod.koul@Intel.com>
> ---
>
> Dan,
>
> Looks like you fixed up the DesignWare driver for the same issue but
> this needs it to.
>
> drivers/dma/at_hdmac_regs.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
> index f31d647acdfa..2787aba60c6b 100644
> --- a/drivers/dma/at_hdmac_regs.h
> +++ b/drivers/dma/at_hdmac_regs.h
> @@ -347,10 +347,6 @@ static struct device *chan2dev(struct dma_chan *chan)
> {
> return &chan->dev->device;
> }
> -static struct device *chan2parent(struct dma_chan *chan)
> -{
> - return chan->dev->device.parent;
> -}
>
> #if defined(VERBOSE_DEBUG)
> static void vdbg_dump_regs(struct at_dma_chan *atchan)
> --
> 1.8.4.1.601.g02b3b1d
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
prev parent reply other threads:[~2013-11-28 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 18:43 [PATCH] dmaengine: at_hdmac: remove unused function Olof Johansson
2013-11-27 9:55 ` Nicolas Ferre
2013-11-27 10:54 ` Bartlomiej Zolnierkiewicz
2013-11-28 6:01 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128060149.GP8834@intel.com \
--to=vinod.koul@intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).