From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Mike Galbraith <efault@gmx.de>, David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 7/7] perf inject: Handle output file via perf_data_file object
Date: Thu, 28 Nov 2013 16:30:31 +0100 [thread overview]
Message-ID: <20131128153031.GA31444@krava.brq.redhat.com> (raw)
In-Reply-To: <20131128141435.GC3603@infradead.org>
On Thu, Nov 28, 2013 at 12:14:35PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 28, 2013 at 11:30:19AM +0100, Jiri Olsa escreveu:
> > Using the perf_data_file object to handle output
> > file processing.
> >
> > No functional change intended.
>
> There is one, before we were using:
>
> - inject.output = open(output_name, O_CREAT | O_WRONLY | O_TRUNC,
> - S_IRUSR | S_IWUSR);
>
> And
>
> + if (perf_data_file__open(&inject.output)) {
>
> Does:
>
> return open(file->path, O_CREAT|O_RDWR|O_TRUNC, S_IRUSR|S_IWUSR);
>
> Why do we need to do O_RDWR there? Can we live with plain O_WRONLY as
> before?
I think the reason is the record's buildid's hunt
during the exit.. we read the file we just stored
without reopening it for reading
hum, how about the output file mmapping David is working on,
that might need file to be readable as well..
>
> Also, while reviewing this I got something that I missed in previous
> patches, I think we could reuse:
>
> O_WRONLY to replace the long constant PERF_DATA_MODE_WRITE
> O_RDONLY ditto -> PERF_DATA_MODE_READ
>
> Shorter, and matches what we need here: a open flag value to specify
> which access mode the perf.data file is operating, no?
I guess that would work.. but I planned for future more
perf specific flags like PERF_DATA_MODE_DIR or something
like that.. I haven't this fully thought through yet..
jirka
next prev parent reply other threads:[~2013-11-28 15:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 10:30 [PATCHv2 0/7] perf tools: Add data file write interface Jiri Olsa
2013-11-28 10:30 ` [PATCH 1/7] perf record: Unify data output code into perf_record__write function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 2/7] perf tools: Use correct return type for readn function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 3/7] perf tools: Fine tune " Jiri Olsa
2013-11-28 15:19 ` David Ahern
2013-11-28 15:43 ` [PATCHv3 " Jiri Olsa
2013-11-28 16:03 ` David Ahern
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 4/7] perf tools: Add writen function Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 5/7] perf tools: Add perf_data_file__write interface Jiri Olsa
2013-12-04 15:40 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-11-28 10:30 ` [PATCH 6/7] perf record: Use perf_data_file__write for output file Jiri Olsa
2013-11-28 14:03 ` Arnaldo Carvalho de Melo
2013-11-28 15:21 ` [PATCHv3 " Jiri Olsa
2013-11-28 10:30 ` [PATCH 7/7] perf inject: Handle output file via perf_data_file object Jiri Olsa
2013-11-28 14:14 ` Arnaldo Carvalho de Melo
2013-11-28 15:30 ` Jiri Olsa [this message]
2013-11-28 10:36 ` [PATCHv2 0/7] perf tools: Add data file write interface Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128153031.GA31444@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).