From: Matt Porter <matt.porter@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Christian Daudt <bcm@fixthebug.org>,
Paul Zimmerman <paulz@synopsys.com>,
Tomasz Figa <t.figa@samsung.com>,
Kamil Debski <k.debski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Linux USB List <linux-usb@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linaro Patches <patches@linaro.org>
Subject: Re: [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
Date: Thu, 28 Nov 2013 11:41:38 -0500 [thread overview]
Message-ID: <20131128164138.GS31091@beef> (raw)
In-Reply-To: <5296DA70.8010409@ti.com>
On Thu, Nov 28, 2013 at 11:23:52AM +0530, Kishon Vijay Abraham I wrote:
> On Thursday 28 November 2013 04:06 AM, Matt Porter wrote:
> > On Wed, Nov 27, 2013 at 12:13:25PM -0500, Matt Porter wrote:
> >> On Tue, Nov 26, 2013 at 03:53:32PM +0530, Kishon Vijay Abraham I wrote:
> >>> Hi,
> >>>
> >>> On Monday 25 November 2013 11:46 PM, Matt Porter wrote:
> >>>> If a generic phy is present, call phy_init()/phy_exit(). This supports
> >>>> generic phys that must be soft reset before power on.
> >>>>
> >>>> Signed-off-by: Matt Porter <matt.porter@linaro.org>
> >>>> ---
> >>>> drivers/usb/gadget/s3c-hsotg.c | 5 +++++
> >>>> 1 file changed, 5 insertions(+)
> >>>>
> >>>> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> >>>> index da3879b..8dfe33f 100644
> >>>> --- a/drivers/usb/gadget/s3c-hsotg.c
> >>>> +++ b/drivers/usb/gadget/s3c-hsotg.c
> >>>> @@ -3622,6 +3622,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
> >>>> goto err_supplies;
> >>>> }
> >>>>
> >>>> + if (hsotg->phy)
> >>>
> >>> IS_ERR? If your phy_get fails *phy* will have a error value..
> >>
> >> Yes, thanks. I'll fix these and also note that the same issue exists in
> >> Kamil's patch for these same hsotg->phy conditional uses. I'll work with
> >> Kamil to either get those addressed there or in a follow on fix.
> >
> > I spoke too soon. If devm_phy_get fails, we don't set hsotg->phy and probe
> > defer thus not reaching this point. Since hsotg->phy is either NULL or a
> > valid struct phy *, this is correct as is throughout the driver.
> >
> >>>
> >>>> + phy_init(hsotg->phy);
> >>>> +
> >>>> /* usb phy enable */
> >>>> s3c_hsotg_phy_enable(hsotg);
> >>>>
> >>>> @@ -3715,6 +3718,8 @@ static int s3c_hsotg_remove(struct platform_device *pdev)
> >>>> }
> >>>>
> >>>> s3c_hsotg_phy_disable(hsotg);
> >>>> + if (hsotg->phy)
> >>>
> >>> same here.
> >>
> >> Ok.
> >
> > Same above, this will be NULL on failure (but is only applicable at this
> > point on the platform data path.
>
> Ah ok.. Btw where is phy_get being called? Is it not part of this series?
It's in the Kamil's Exynos USB Phy -> generic phy series [1] which I depend
on here. I mentioned it in the cover letter toward the end so it's a bit
buried.
I have some outstanding, but trivial, comments on that series but I hear
Kamil will be posting an update in the coming days. I'll wait a few days
to post v4 addressing your comments so I can hopefully rebase against
his updated s3c-hsotg patch.
-Matt
[1] https://lkml.org/lkml/2013/11/5/275
next prev parent reply other threads:[~2013-11-28 16:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 18:15 [PATCH v3 0/9] USB Device Controller support for BCM281xx Matt Porter
2013-11-25 18:15 ` [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls Matt Porter
2013-11-26 10:16 ` Kishon Vijay Abraham I
2013-11-27 16:55 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties Matt Porter
2013-11-26 10:19 ` Kishon Vijay Abraham I
2013-11-27 16:56 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter
2013-11-25 18:16 ` [PATCH v3 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 compatible string Matt Porter
2013-11-25 18:16 ` [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support Matt Porter
2013-11-26 10:23 ` Kishon Vijay Abraham I
2013-11-27 17:13 ` Matt Porter
2013-11-27 22:36 ` Matt Porter
2013-11-28 5:53 ` Kishon Vijay Abraham I
2013-11-28 16:41 ` Matt Porter [this message]
2013-11-28 17:02 ` Kamil Debski
2013-11-25 18:16 ` [PATCH v3 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem Matt Porter
2013-11-26 10:28 ` Kishon Vijay Abraham I
2013-11-27 17:16 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding Matt Porter
2013-11-26 10:31 ` Kishon Vijay Abraham I
2013-11-27 17:19 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 8/9] phy: add Broadcom Kona USB2 PHY driver Matt Porter
2013-11-27 8:51 ` Kishon Vijay Abraham I
2013-11-27 17:21 ` Matt Porter
2013-11-25 18:16 ` [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx Matt Porter
2013-11-27 8:57 ` Kishon Vijay Abraham I
2013-11-27 17:24 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128164138.GS31091@beef \
--to=matt.porter@linaro.org \
--cc=balbi@ti.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.debski@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@linaro.org \
--cc=paulz@synopsys.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).